Skip to content

feat!: esm only #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

feat!: esm only #3540

merged 1 commit into from
Jul 4, 2025

Conversation

Shinigami92
Copy link
Member

This PR is theoretically the same as #3513 but without the test change from #3436 and only the cjs removal itself

@Shinigami92 Shinigami92 added this to the v10.0 milestone Jun 29, 2025
@Shinigami92 Shinigami92 self-assigned this Jun 29, 2025
@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Jun 29, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 29, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f69ae71
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6867ff50e9c6f60008d99be9
😎 Deploy Preview https://deploy-preview-3540.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov Codecov
Copy link

codecov bot commented Jun 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (4e422f7) to head (f69ae71).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3540   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2888     2888           
  Lines      222112   222112           
  Branches      949      952    +3     
=======================================
  Hits       222059   222059           
  Misses         53       53
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92
Copy link
Member Author

Well, in the failing node-18 pipeline we can actively see that the drop of node-18 IS required
This will happen in #3536

@Shinigami92 Shinigami92 marked this pull request as ready for review June 29, 2025 14:16
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 29, 2025 14:16
@Shinigami92 Shinigami92 mentioned this pull request Jun 29, 2025
Merged
@Shinigami92 Shinigami92 force-pushed the feat-esm-only branch 2 times, most recently from 487e5b4 to 94bf307 Compare July 3, 2025 16:28
@Shinigami92 Shinigami92 marked this pull request as draft July 3, 2025 16:33
@Shinigami92 Shinigami92 force-pushed the feat-esm-only branch 2 times, most recently from 54cac78 to 43a6ec1 Compare July 4, 2025 14:32
@Shinigami92 Shinigami92 marked this pull request as ready for review July 4, 2025 14:38
@Shinigami92 Shinigami92 enabled auto-merge July 4, 2025 14:38
xDivisionByZerox
xDivisionByZerox reviewed Jul 4, 2025
View reviewed changes
@Shinigami92 Shinigami92 force-pushed the feat-esm-only branch 2 times, most recently from 4a2dc14 to 45df921 Compare July 4, 2025 15:06
@Shinigami92 Shinigami92 linked an issue Jul 4, 2025 that may be closed by this pull request
Remove Node v18 Support #3514
Closed
@Shinigami92 Shinigami92 added this pull request to the merge queue Jul 4, 2025
Merged via the queue into next with commit 160960b Jul 4, 2025
23 checks passed
@Shinigami92 Shinigami92 deleted the feat-esm-only branch July 4, 2025 17:36
@Shinigami92 Shinigami92 mentioned this pull request Jul 4, 2025
Closed
@matthewmayer matthewmayer mentioned this pull request Jul 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Remove Node v18 Support
2 participants
@Shinigami92 @xDivisionByZerox