Skip to content

feat(locale): add vehicle locale data for Japanese #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

feat(locale): add vehicle locale data for Japanese #3490

merged 2 commits into from
Apr 29, 2025

Conversation

noritaka1166
Copy link
Contributor

This pull request adds support for fuel and type definitions in the vehicle module for the Japanese locale.

@noritaka1166 noritaka1166 requested a review from a team as a code owner April 26, 2025 12:52
@netlify Netlify
Copy link

netlify bot commented Apr 26, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f9994bb
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/68110945a4503300080e8f27
😎 Deploy Preview https://deploy-preview-3490.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Apr 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (786a3d0) to head (88e8a14).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3490   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2866     2869    +3     
  Lines      219789   219810   +21     
  Branches      952      950    -2     
=======================================
+ Hits       219736   219757   +21     
  Misses         53       53
Files with missing lines Coverage Δ
src/locales/ja/index.ts 100.00% <100.00%> (ø)
src/locales/ja/vehicle/fuel.ts 100.00% <100.00%> (ø)
src/locales/ja/vehicle/index.ts 100.00% <100.00%> (ø)
src/locales/ja/vehicle/type.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Shinigami92
Shinigami92 reviewed Apr 28, 2025
View reviewed changes
Shinigami92
Shinigami92 previously approved these changes Apr 29, 2025
View reviewed changes
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module labels Apr 29, 2025
@Shinigami92 Shinigami92 added this to the vAnytime milestone Apr 29, 2025
xDivisionByZerox
xDivisionByZerox previously approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good 👍
Would you be so kind to update the snapshot file again? Stacking PRs of the same locale, sadly results in merge conflicts. I saw that you opened other PRs as well. After this PR is merged, I would write you in the PR I'm planning on getting merged next. That way you do not need to endlessly update all snapshots test, just for another PR merge causing conflicts again. 🙂

@xDivisionByZerox xDivisionByZerox added the needs rebase There is a merge conflict label Apr 29, 2025
@noritaka1166
Copy link
Contributor Author

@xDivisionByZerox
I rebased it.

@noritaka1166 noritaka1166 dismissed xDivisionByZerox’s stale review April 29, 2025 16:56

The merge-base changed after approval.

@xDivisionByZerox xDivisionByZerox requested a review from a team April 29, 2025 16:56
@xDivisionByZerox
Copy link
Member

The merge-base changed after approval.

Oh I see. Funny enough, GH showed the files from the previous PR as already reviewed, so I didn't noticed.

Looking at the commit history I'd say you didn't force push at the end of your rebase (?). 🤔
A normal merge commit from next would have ben enough as well. I'm sorry if the label did confuse you.

@xDivisionByZerox
Copy link
Member

The commit b70e793 is definitely incorrect in here. And the commits "feat(locale): add vehicle locale data for Japanese" and "feat(locale): remove 'SUV' from Japanese vehicle types" are currently duplicated.
Can you fix that?
If you need help fixing your history you can write a message. I'll gladly help you.

@noritaka1166 noritaka1166 force-pushed the add-japanese-vehicle branch from 13ba292 to f9994bb Compare April 29, 2025 17:15
@noritaka1166
Copy link
Contributor Author

The merge-base changed after approval.

Oh I see. Funny enough, GH showed the files from the previous PR as already reviewed, so I didn't noticed.

Looking at the commit history I'd say you didn't force push at the end of your rebase (?). 🤔 A normal merge commit from next would have ben enough as well. I'm sorry if the label did confuse you.

Sorry...

@noritaka1166
Copy link
Contributor Author

noritaka1166 commented Apr 29, 2025 •
edited
Loading

The commit b70e793 is definitely incorrect in here. And the commits "feat(locale): add vehicle locale data for Japanese" and "feat(locale): remove 'SUV' from Japanese vehicle types" are currently duplicated. Can you fix that? If you need help fixing your history you can write a message. I'll gladly help you.

@xDivisionByZerox
I fixed it.
How about this?

@xDivisionByZerox
Copy link
Member

How about this?

Thank you so much 🙏

@xDivisionByZerox xDivisionByZerox removed the needs rebase There is a merge conflict label Apr 29, 2025
@xDivisionByZerox xDivisionByZerox removed this from the vAnytime milestone Apr 29, 2025
@xDivisionByZerox xDivisionByZerox added this to the v9.x milestone Apr 29, 2025
@xDivisionByZerox xDivisionByZerox merged commit dfadb1d into faker-js:next Apr 29, 2025
24 checks passed
@xDivisionByZerox
Copy link
Member

Thank you for your contribution @noritaka1166 ❤️🙏

I see that this was your first contribution to our project.
Would you mind answering some questions regarding your contribution? This way we can understand the potential struggles or confusions new contributors might have when getting into the project.

  1. What did motivate you to do your contribution?
  2. Did you read our documentation regarding contributing before starting to work on your contribution?
  3. How clear was the process of working on your contribution (before the PR) for you? Was there ever a time while working in the project where you didn't know what to do? If so how did you solve your problem?
  4. How clear was the process of the code review (PR) for you? Was there ever a time you felt unsure about the current situation?
  5. Anything else you'd like to share with the Faker team?

If you don't want to answer, please ignore this comment.

@noritaka1166
Copy link
Contributor Author

@xDivisionByZerox

  1. What did motivate you to do your contribution?

I use faker to randomly add people's names, company names, etc. when I run E2E tests.
It's been useful, so I thought I'd like to contribute.

  1. Did you read our documentation regarding contributing before starting to work on your contribution?

Yes.

  1. How clear was the process of working on your contribution (before the PR) for you? Was there ever a time while working in the project where you didn't know what to do? If so how did you solve your problem?

A useful command (pnpm run preflight) was provided so I could concentrate only on adding or updating the locale.

  1. How clear was the process of the code review (PR) for you? Was there ever a time you felt unsure about the current situation?

No problem.

  1. Anything else you'd like to share with the Faker team?

Thanks for developing faker.
I will continue to cooperate with this OSS!

@noritaka1166 noritaka1166 deleted the add-japanese-vehicle branch May 23, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@noritaka1166 noritaka1166

Labels
c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.x
Development

Successfully merging this pull request may close these issues.
3 participants
@noritaka1166 @xDivisionByZerox @Shinigami92