Skip to content

test: use validator@13.15.0 with isULID, isISO31661Numeric, isISO15924 #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

test: use validator@13.15.0 with isULID, isISO31661Numeric, isISO15924 #3482

merged 3 commits into from
Apr 17, 2025

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Apr 15, 2025 •
edited
Loading

By upgrading @types/validator to @13.15.0 we can take advantage of the new functions isULID, isISO31661Numeric and isISO15924 from validator to improve and simplify tests.

@netlify Netlify
Copy link

netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4d2624d
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/68013f8ba4dc5200084ee55b
😎 Deploy Preview https://deploy-preview-3482.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (242cc79) to head (4d2624d).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3482   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2838     2838           
  Lines      218606   218606           
  Branches      949      949           
=======================================
  Hits       218553   218553           
  Misses         53       53
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewmayer matthewmayer self-assigned this Apr 15, 2025
@matthewmayer matthewmayer changed the title feat(tests): use validator@13.15.0 with isULID, isISO31661Numeric, isISO15924 test: use validator@13.15.0 with isULID, isISO31661Numeric, isISO15924 Apr 15, 2025
@matthewmayer matthewmayer marked this pull request as ready for review April 15, 2025 13:03
@matthewmayer matthewmayer requested a review from a team as a code owner April 15, 2025 13:03
@Shinigami92 Shinigami92 added this to the vAnytime milestone Apr 15, 2025
xDivisionByZerox
xDivisionByZerox approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the checks prior to the validation function still useful? Since validator works with regex under the hood most of the time, I'm not seeing how having two regex is useful for us.

@matthewmayer
Copy link
Contributor Author

Are the checks prior to the validation function still useful? Since validator works with regex under the hood most of the time, I'm not seeing how having two regex is useful for us.

I don't see much point in removing them

@xDivisionByZerox xDivisionByZerox merged commit 04e4346 into faker-js:next Apr 17, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: test p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewmayer @Shinigami92 @xDivisionByZerox