Skip to content

Conversation

yyz945947732
Copy link
Contributor

locale zh_CN animal update birdinsectpet_name and fix some typos.

@yyz945947732 yyz945947732 requested a review from a team as a code owner April 15, 2025 07:35
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 46682b8
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6803d9acf18e4a000862fa82
😎 Deploy Preview https://deploy-preview-3480.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shinigami92 Shinigami92 added c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Apr 15, 2025
@Shinigami92 Shinigami92 added this to the vAnytime milestone Apr 15, 2025
Shinigami92
Shinigami92 previously approved these changes Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (456f102) to head (46682b8).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3480   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2856     2859    +3     
  Lines      219441   219518   +77     
  Branches      950      949    -1     
=======================================
+ Hits       219386   219465   +79     
+ Misses         55       53    -2     
Files with missing lines Coverage Δ
src/locales/zh_CN/animal/bear.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/bird.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/cat.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/dog.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/insect.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/pet_name.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/type.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matthewmayer
matthewmayer previously approved these changes Apr 16, 2025
@xDivisionByZerox
Copy link
Member

I'll review this PR later on. @yyz945947732 can you resolve the merge conflicts if you find the time, please.

@yyz945947732 yyz945947732 dismissed stale reviews from matthewmayer and Shinigami92 via 46682b8 April 19, 2025 17:13
@yyz945947732
Copy link
Contributor Author

I'll review this PR later on. @yyz945947732 can you resolve the merge conflicts if you find the time, please.

Done. I'm off to bed now 😴. I’ll check back in during the day when I have time (probably when you’re already asleep 💤).

@xDivisionByZerox
Copy link
Member

I'll merge with only one approval, since the PR initially already collected enough approvals.

@xDivisionByZerox xDivisionByZerox merged commit 38ee7b8 into faker-js:next Apr 24, 2025
23 checks passed
@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent labels Apr 24, 2025
@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v9.x May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants