Skip to content

feat(locale): add cy locale, start with date #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2025
Merged

feat(locale): add cy locale, start with date #3462

merged 4 commits into from
Apr 11, 2025

Conversation

Awen23
Copy link
Contributor

@Awen23 Awen23 commented Apr 1, 2025

Add Welsh locale, start with date module

I've got some other modules ready/in progress, but it looks like one module at a time is the preferred way so starting with just date

@Awen23 Awen23 requested a review from a team as a code owner April 1, 2025 15:13
@netlify Netlify
Copy link

netlify bot commented Apr 1, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 6f3c43f
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67f9505de9353200081ea670
😎 Deploy Preview https://deploy-preview-3462.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions m: date Something is referring to the date module labels Apr 1, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 1, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (b2c5298) to head (6f3c43f).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3462   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2830     2836    +6     
  Lines      218533   218603   +70     
  Branches      951      952    +1     
=======================================
+ Hits       218480   218550   +70     
  Misses         53       53
Files with missing lines Coverage Δ
src/locale/cy.ts 100.00% <100.00%> (ø)
src/locale/index.ts 100.00% <100.00%> (ø)
src/locales/cy/date/index.ts 100.00% <100.00%> (ø)
src/locales/cy/date/month.ts 100.00% <100.00%> (ø)
src/locales/cy/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/cy/index.ts 100.00% <100.00%> (ø)
src/locales/cy/metadata.ts 100.00% <100.00%> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox requested review from a team April 1, 2025 21:09
@xDivisionByZerox xDivisionByZerox merged commit f70a6f7 into faker-js:next Apr 11, 2025
23 checks passed
@xDivisionByZerox
Copy link
Member

Thank you for your contribution @Awen23 ❤️👏

I see that this was your first contribution to our project.
Would you mind answering some questions regarding your contribution? This way we can understand the potential struggles or confusions new contributors might have when getting into the project. If you don't want to answer, please ignore this comment:

  1. What did motivate you to do your contribution?
  2. Did you read our documentation regarding contributing before starting to work on your contribution?
  3. How clear was the process of working on your contribution (before the PR) for you? Was there ever a time while working in the project where you didn't know what to do? If so how did you solve your problem?
  4. How clear was the process of the code review (PR) for you? Was there ever a time you felt unsure about the current situation?
  5. Anything else you'd like to share with the Faker team?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Awen23 Awen23

Labels
c: feature Request for new feature c: locale Permutes locale definitions m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@Awen23 @xDivisionByZerox @matthewmayer @Shinigami92