Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 1, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node (source) 22.13.8 -> 22.14.0 age adoption passing confidence
@types/sanitize-html (source) 2.13.0 -> 2.15.0 age adoption passing confidence
@types/semver (source) 7.5.8 -> 7.7.0 age adoption passing confidence
@types/validator (source) 13.12.2 -> 13.12.3 age adoption passing confidence
@vueuse/core (source) 12.7.0 -> 12.8.2 age adoption passing confidence
cypress (source) 14.1.0 -> 14.3.0 age adoption passing confidence
prettier-plugin-packagejson 2.5.9 -> 2.5.10 age adoption passing confidence
sanitize-html 2.14.0 -> 2.15.0 age adoption passing confidence
validator 13.12.0 -> 13.15.0 age adoption passing confidence
vue-tsc (source) 2.2.6 -> 2.2.8 age adoption passing confidence

Release Notes

vueuse/vueuse (@​vueuse/core)

v12.8.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v12.8.1

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v12.8.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub
cypress-io/cypress (cypress)

v14.3.0

Compare Source

Changelog: https://docs.cypress.io/app/references/changelog#14-3-0

v14.2.1

Compare Source

Changelog: https://docs.cypress.io/app/references/changelog#14-2-1

v14.2.0

Compare Source

Changelog: https://docs.cypress.io/app/references/changelog#14-2-0

matzkoh/prettier-plugin-packagejson (prettier-plugin-packagejson)

v2.5.10

Compare Source

Bug Fixes
  • deps: update dependency sort-package-json to v2.15.1 (b10ddae)
apostrophecms/sanitize-html (sanitize-html)

v2.15.0

Compare Source

  • Allow keeping tag content when discarding with exclusive filter by returning "excludeTag". Thanks to rChaoz.
validatorjs/validator.js (validator)

v13.15.0

Compare Source

New Features / Validators
Fixes, New Locales and Enhancements
vuejs/language-tools (vue-tsc)

v2.2.8

Compare Source

Bug Fixes
  • revert "fix(language-core): validate v-model variable against model type"

Configuration

📅 Schedule: Branch creation - "* 0-3 1 * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner April 1, 2025 01:32
@renovate renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels Apr 1, 2025
@renovate renovate bot added this to the vAnytime milestone Apr 1, 2025
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 3dc03a0
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67f59e82ee5ef50008a52a82
😎 Deploy Preview https://deploy-preview-3456.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@renovate renovate bot force-pushed the renovate/devdependencies branch 4 times, most recently from a1b5099 to f2f8dc0 Compare April 1, 2025 22:28
@matthewmayer
Copy link
Contributor

matthewmayer commented Apr 2, 2025

looks like there have been some changes to isIBAN in validator which cause failure

//validator@13.12.0
validator.isIBAN("IE06 0192 5502 8613 0093 62") //true

//validator@13.15.0
validator.isIBAN("IE06 0192 5502 8613 0093 62") //false

this is the fix in question https://github.com/validatorjs/validator.js/pull/2518/files

@Shinigami92
Copy link
Member

This PR will be automatically rebased by Renovate after we merged #3464

@renovate renovate bot force-pushed the renovate/devdependencies branch from 3085cca to 8e6670c Compare April 5, 2025 17:54
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (7b12056) to head (3dc03a0).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3456   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2819     2819           
  Lines      217500   217500           
  Branches      951      951           
=======================================
+ Hits       217445   217447    +2     
+ Misses         55       53    -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Shinigami92
Shinigami92 previously approved these changes Apr 5, 2025
@renovate renovate bot force-pushed the renovate/devdependencies branch from 8e6670c to 3dc03a0 Compare April 8, 2025 22:09
@matthewmayer
Copy link
Contributor

I see the @types/validator package is not updated yet does it matter if these are out of sync?

@Shinigami92
Copy link
Member

I see the @types/validator package is not updated yet does it matter if these are out of sync?

If there would be a problem, it would trigger a failure in ts-check, but https://github.com/faker-js/faker/actions/runs/14344536797/job/40211523250?pr=3456 is green ✅

@Shinigami92 Shinigami92 merged commit 2cb4635 into next Apr 9, 2025
27 checks passed
@Shinigami92 Shinigami92 deleted the renovate/devdependencies branch April 9, 2025 09:47
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Apr 10, 2025

If there would be a problem, it would trigger a failure in ts-check, but faker-js/faker/actions/runs/14344536797/job/40211523250?pr=3456 is green ✅

Just for the future, this is only partially correct. If for example a function in the validator package would have removed a parameter, we would not be notified about this change, because the "old" types package would still be advertising the parameter. Similar, I know that v13.15.0 introduced the isISO15924() validator which we have been waiting for since 2 years (check the PR timeline lol). Since the types package is not synchronized, we can't actually use this function, because typescript is not aware that this function exists.

Is not really a bit problem, since we can just update next week (hopefully). I just wanted to clarify that it's not as easy as you stated.

@matthewmayer
Copy link
Contributor

If there would be a problem, it would trigger a failure in ts-check, but faker-js/faker/actions/runs/14344536797/job/40211523250?pr=3456 is green ✅

Just for the future, this is only partially correct. If for example a function in the validator package would have removed a parameter, we would not be notified about this change, because the "old" types package would still be advertising the parameter. Similar, I know that v13.15.0 introduced the isISO15924() validator which we have been waiting for since 2 years (check the PR timeline lol). Since the types package is not synchronized, we can't actually use this function, because typescript is not aware that this function exists.

Is not really a bit problem, since we can just update next week (hopefully). I just wanted to clarify that it's not as easy as you stated.

Right, it was the new functions like isISO15924, isISO31661Numeric and isULID i was wondering about as they would be useful in tests. Is there some automated way to add these types or does it need to be done by hand and added to https://github.com/DefinitelyTyped/DefinitelyTyped/pulls ?

@Shinigami92
Copy link
Member

[...] If for example a function in the validator package would have removed a parameter, we would not be notified about this change, because the "old" types package would still be advertising the parameter. [...]

I understand what you mean, but I would still expect in that case that the test would fail somehow when such a parameter is not used anymore.

@types/* packages are always a bit behind, but I had very few issues to that in the past. And if there is really something we can benefit from which is not supported yet, then everyone is welcome to contribute to DefinitelyTyped.

So @matthewmayer: yeah, first search if there is already an open PR, otherwise open a new one 🙂
The contribution process is well documented

@matthewmayer
Copy link
Contributor

@WikiRik wonder if we might be able to get your help updating the @types/validator package to support the new functions in 13.15.0?

@WikiRik
Copy link

WikiRik commented Apr 12, 2025

@matthewmayer thanks for the ping. I'm happy to help out! Would you like me to review a PR for new types or would you prefer that I work on a PR myself?

@matthewmayer
Copy link
Contributor

@matthewmayer thanks for the ping. I'm happy to help out! Would you like me to review a PR for new types or would you prefer that I work on a PR myself?

I did have a go at doing it myself but to be honest it's a bit beyond my typescript abilities. So I don't want to burden you but if you already know how to I'd appreciate if you have a crack. No hurry 😀

@WikiRik
Copy link

WikiRik commented Apr 12, 2025

I've opened DefinitelyTyped/DefinitelyTyped#72475 for the changes in the newest validator.js release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants