Skip to content

feat(locale): add localize sex support for zh_CN & zh_TW #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

feat(locale): add localize sex support for zh_CN & zh_TW #3450

merged 2 commits into from
Apr 1, 2025

Conversation

sd44
Copy link
Contributor

@sd44 sd44 commented Mar 31, 2025

No description provided.

@sd44 sd44 requested a review from a team as a code owner March 31, 2025 09:22
@netlify Netlify
Copy link

netlify bot commented Mar 31, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 48d1ee2
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67eb39a38640480008293efd
😎 Deploy Preview https://deploy-preview-3450.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sd44 sd44 changed the title add localize sex for zh_CN & zh_TW feat(locale): add localize sex support for zh_CN & zh_TW Mar 31, 2025
@xDivisionByZerox xDivisionByZerox requested a review from a team March 31, 2025 16:12
@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Mar 31, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Mar 31, 2025
@xDivisionByZerox
Copy link
Member

Please update the snapshot test. You can do that by running pnpm run test:update-snapshots locally.

@codecov Codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (479b271) to head (48d1ee2).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3450   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2817     2819    +2     
  Lines      217494   217500    +6     
  Branches      950      949    -1     
=======================================
+ Hits       217439   217445    +6     
  Misses         55       55
Files with missing lines Coverage Δ
src/locales/zh_CN/person/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/person/sex.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/person/index.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/person/sex.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox merged commit 048c325 into faker-js:next Apr 1, 2025
23 checks passed
@xDivisionByZerox
Copy link
Member

Thank you for your contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@sd44 sd44

Labels
c: feature Request for new feature c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@sd44 @xDivisionByZerox @matthewmayer @Shinigami92