Skip to content

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 3, 2024

Fixes #3291


This PR adds the missing example results to faker.helpers.uniqueArray.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels Dec 3, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 3, 2024
@ST-DDT ST-DDT requested review from a team December 3, 2024 18:29
@ST-DDT ST-DDT self-assigned this Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 6407504
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/674f4e0c0d458b0008b0c534
😎 Deploy Preview https://deploy-preview-3321.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (1bfa1fa) to head (6407504).
Report is 5 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3321      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217086   217086              
  Branches      975      970       -5     
==========================================
- Hits       217027   217016      -11     
- Misses         59       70      +11     
Files with missing lines Coverage Δ
src/modules/helpers/index.ts 96.71% <ø> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT added this pull request to the merge queue Dec 6, 2024
Merged via the queue into next with commit d721b3a Dec 6, 2024
28 checks passed
@ST-DDT ST-DDT deleted the docs/helpers/uniqueArray branch December 6, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

faker.helpers.uniqueArray examples are incomplete and broken
2 participants