Skip to content

docs: faker.seed examples are not consistent after refresh #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2025
Merged

docs: faker.seed examples are not consistent after refresh #3378

merged 4 commits into from
Jan 25, 2025

Conversation

matthewmayer
Copy link
Contributor

fix #3345

@matthewmayer matthewmayer requested a review from a team as a code owner January 20, 2025 00:58
@matthewmayer matthewmayer self-assigned this Jan 20, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 20, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ea23fb3
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6794e12a31fa580008633561
😎 Deploy Preview https://deploy-preview-3378.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jan 20, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (51dddb8) to head (ea23fb3).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3378   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      217035   217035           
  Branches      941      940    -1     
=======================================
  Hits       216984   216984           
  Misses         51       51
Files with missing lines Coverage Δ
src/simple-faker.ts 100.00% <ø> (ø)

xDivisionByZerox
xDivisionByZerox previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on the deplyo preview. 👍

ejcheng
ejcheng previously approved these changes Jan 21, 2025
View reviewed changes
@ST-DDT
Copy link
Member

ST-DDT commented Jan 23, 2025

Should we change these as well? (middle signature)

faker/src/simple-faker.ts

Lines 208 to 214 in dc467c0

* faker.seed([42, 13, 17])
* faker.number.int(10); // 4
* faker.number.int(10); // 8
*
* faker.seed([42, 13, 17])
* faker.number.int(10); // 4
* faker.number.int(10); // 8

@xDivisionByZerox
Copy link
Member

Should we change these as well? (middle signature)

Yes, propably.

@matthewmayer matthewmayer dismissed stale reviews from ejcheng and xDivisionByZerox via 905c9b9 January 25, 2025 05:09
ST-DDT
ST-DDT reviewed Jan 25, 2025
View reviewed changes
@ST-DDT ST-DDT merged commit 292920f into faker-js:next Jan 25, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng ejcheng left review comments

@xDivisionByZerox xDivisionByZerox xDivisionByZerox left review comments

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

faker.seed examples are not consistent after refresh
4 participants
@matthewmayer @ST-DDT @xDivisionByZerox @ejcheng