refactor(locale): improve product_name data in en and tr #3372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Nice catch. Please run |
ST-DDT
approved these changes
Jan 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3372 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2811 2811
Lines 217023 217035 +12
Branches 942 941 -1
=======================================
+ Hits 216970 216982 +12
Misses 53 53
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For en locale, Frozen, Fresh, and Soft were in materials category although they should have been in adjectives. I moved them and also expanded the materials category.
For the tr locale, I did the corresponding changes for the same items. Translations are confirmed by me as a native Turkish speaker. Below you can see which corresponds to which:
Dondurulmuş(Frozen), Taze(Fresh), Yumuşak(Soft), Altın(Gold), Alüminyum(Aluminum), Bambu(Bamboo), Mermer(Marble), Seramik(Ceramic), İpek(Silk)