Skip to content

refactor(locale): improve zh_CN vehicle manufacturers #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2024
Merged

refactor(locale): improve zh_CN vehicle manufacturers #3254

merged 3 commits into from
Nov 11, 2024

Conversation

Heuluck
Copy link
Contributor

@Heuluck Heuluck commented Nov 9, 2024

Use the correct translations, and add some vehicle manufacturers to zh_CN

@Heuluck Heuluck requested a review from a team as a code owner November 9, 2024 18:19
@netlify Netlify
Copy link

netlify bot commented Nov 9, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 9aa8f5d
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6731c4e074896d00082233c4
😎 Deploy Preview https://deploy-preview-3254.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ejcheng ejcheng added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Nov 9, 2024
@ejcheng ejcheng added this to the vAnytime milestone Nov 9, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (ff93362) to head (9aa8f5d).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #3254      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      217115   217129      +14     
  Branches      973      974       +1     
==========================================
+ Hits       217030   217038       +8     
- Misses         85       91       +6
Files with missing lines Coverage Δ
src/locales/zh_CN/vehicle/manufacturer.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

ST-DDT
ST-DDT requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pnpm run preflight once and commit the changes.

@Heuluck Heuluck requested a review from ST-DDT November 10, 2024 03:10
ST-DDT
ST-DDT approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR and quick fixes ❤️ .

I checked with Google translate and it looks good to me, but I would love to have a native speaker review this as well.

@ST-DDT ST-DDT requested review from a team November 10, 2024 07:51
@ST-DDT ST-DDT changed the title feat(locale): improve and add vehicle manufacturers to zh_CN refactor(locale): improve zh_CN vehicle manufacturers Nov 10, 2024
@ST-DDT ST-DDT added the m: vehicle Something is referring to the vehicle module label Nov 10, 2024
@Heuluck
Copy link
Contributor Author

Heuluck commented Nov 10, 2024

It was my first pr so thanks for helping me correcting my mistake

xDivisionByZerox
xDivisionByZerox approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the changes as well by using a translation program.
In the worst case (we don't find any native speaker), I'd say this is good enought and can be changed by later contributors if values are undesired.

@ST-DDT ST-DDT enabled auto-merge (squash) November 11, 2024 08:48
@ST-DDT
Copy link
Member

ST-DDT commented Nov 11, 2024

Thanks for your contribution. ❤️

The changes will be included in the next release, but we don't a release schedule for it yet.

@ST-DDT ST-DDT merged commit 9abaed1 into faker-js:next Nov 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Heuluck Heuluck

Labels
c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@Heuluck @ST-DDT @xDivisionByZerox @ejcheng