infra(commit-and-tag-version): auto-bump version in usage-guide #3250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Cool that you found this, but could you guide me towards documentation on the "scripts" property? I cannot seem to find any references towards that in their documentation. 🤔 |
|
Its part of the commit and tag version plugin config: I'm not sure why there are two different documentations and I consider this one hard to read/understand. You can try the script in a linux docker container.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3250 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2806 2806
Lines 217144 217144
Branches 974 971 -3
==========================================
- Hits 217062 217042 -20
- Misses 82 102 +20 |
xDivisionByZerox
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automates another step from the release process:
Preview
Limitations
Doesn't seem to work on windows maybe because it launches a new CMD instead of (git-)bash
(I don't expect us to do releases locally again though)
Alternatives Considered
I also considered using a js script for the replacing, but that requires converting the
.versionrc.jsonto.versionrc.js.It might be possible to use a ts file instead, if we tsc "compile" it before delegating to commit-and-tag-version in
pnpm run release.