Skip to content

infra(unicorn): prefer-date-now #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2023
Merged

infra(unicorn): prefer-date-now #2419

merged 4 commits into from
Oct 7, 2023

Conversation

Shinigami92
Copy link
Member

⚠️ #2418 needs to be merged first ⚠️

@Shinigami92 Shinigami92 added do NOT merge yet Do not merge this PR into the target branch yet c: infra Changes to our infrastructure or project setup labels Sep 23, 2023
@Shinigami92 Shinigami92 added this to the vAnytime milestone Sep 23, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner September 23, 2023 21:35
@Shinigami92 Shinigami92 self-assigned this Sep 23, 2023
@Shinigami92 Shinigami92 changed the base branch from next to add-eslint-unicorn-dep September 23, 2023 21:36
@Shinigami92 Shinigami92 changed the title chore(deps): add eslint unicorn infra(unicorn): prefer-date-now Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #2419 (970f7b3) into next (93bb134) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2419      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255523   255523              
  Branches     1105     1105              
==========================================
- Hits       254486   254475      -11     
- Misses       1009     1020      +11     
  Partials       28       28
Files Coverage Δ
src/modules/helpers/index.ts 99.12% <100.00%> (ø)
src/modules/helpers/unique.ts 98.70% <100.00%> (ø)

... and 2 files with indirect coverage changes

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior and removed c: infra Changes to our infrastructure or project setup labels Sep 23, 2023
@Shinigami92 Shinigami92 changed the title infra(unicorn): prefer-date-now chore(unicorn): prefer-date-now Sep 23, 2023
ST-DDT
ST-DDT previously approved these changes Sep 23, 2023
View reviewed changes
@Shinigami92 Shinigami92 force-pushed the add-eslint-unicorn-dep branch from 4d917db to d204153 Compare September 23, 2023 23:33
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Sep 25, 2023
Base automatically changed from add-eslint-unicorn-dep to next October 6, 2023 21:14
@xDivisionByZerox xDivisionByZerox dismissed ST-DDT’s stale review October 6, 2023 21:14

The base branch was changed.

@ST-DDT ST-DDT removed the do NOT merge yet Do not merge this PR into the target branch yet label Oct 6, 2023
@ST-DDT ST-DDT assigned ST-DDT and unassigned Shinigami92 Oct 6, 2023
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Oct 6, 2023
@ST-DDT ST-DDT requested review from a team October 6, 2023 23:45
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Oct 6, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Oct 6, 2023

Ready for review and merge.

@ST-DDT ST-DDT changed the title chore(unicorn): prefer-date-now infra(unicorn): prefer-date-now Oct 6, 2023
@ST-DDT ST-DDT removed the c: chore PR that doesn't affect the runtime behavior label Oct 6, 2023
@ST-DDT ST-DDT added the c: infra Changes to our infrastructure or project setup label Oct 6, 2023
@xDivisionByZerox xDivisionByZerox merged commit 57bcd97 into next Oct 7, 2023
@xDivisionByZerox xDivisionByZerox deleted the unicorn/prefer-date-now branch October 7, 2023 08:27
@ST-DDT ST-DDT mentioned this pull request Oct 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @ST-DDT @matthewmayer @xDivisionByZerox