Skip to content

infra(unicorn): use hashbang for scripts #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2023
Merged

infra(unicorn): use hashbang for scripts #2448

merged 4 commits into from
Oct 9, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 7, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 7, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 7, 2023
@ST-DDT ST-DDT requested review from a team October 7, 2023 21:31
@ST-DDT ST-DDT self-assigned this Oct 7, 2023
@ST-DDT ST-DDT mentioned this pull request Oct 7, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Merging #2448 (3524bb6) into next (a1ec929) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3524bb6 differs from pull request most recent head efc4b44. Consider uploading reports for the commit efc4b44 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2448   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files        2823     2823           
  Lines      255525   255523    -2     
  Branches     1101     1105    +4     
=======================================
+ Hits       254467   254470    +3     
+ Misses       1030     1025    -5     
  Partials       28       28

see 3 files with indirect coverage changes

xDivisionByZerox
xDivisionByZerox reviewed Oct 7, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team October 8, 2023 16:15
xDivisionByZerox
xDivisionByZerox reviewed Oct 8, 2023
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I can understand better: You did put the hashbang in all files which are entry files for a script, correct?

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 8, 2023

Just so I can understand better: You did put the hashbang in all files which are entry files for a script, correct?

Yes.

@matthewmayer
Copy link
Contributor

PR title should be updated to reflect adding hashbangs

@ST-DDT ST-DDT changed the title infra(unicorn): no-process-exit infra(unicorn): use hashbang for scripts Oct 8, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 8, 2023

Like this?

@ST-DDT ST-DDT requested a review from a team October 8, 2023 18:12
@ST-DDT ST-DDT enabled auto-merge (squash) October 9, 2023 16:01
@ST-DDT ST-DDT merged commit 72bf57d into next Oct 9, 2023
@ST-DDT ST-DDT deleted the infra/unicorn/no-process-exit branch October 9, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @matthewmayer @xDivisionByZerox