refactor(internet): remove weigths in userAgent #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1761 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 2340 2340
Lines 242653 242619 -34
Branches 1111 1113 +2
=======================================
- Hits 241804 241783 -21
+ Misses 828 815 -13
Partials 21 21
|
ST-DDT
reviewed
Jan 22, 2023
ST-DDT
reviewed
Jan 22, 2023
ST-DDT
approved these changes
Jan 22, 2023
|
The whole random_ua functions seem like overkill, and is hard to maintain (e.g. there's no Edge). Could it just be replaced by a random pick from a static array of popular UAs like: |
Most definitely. I had some other refactoring changes in mind to make this more maintainable in the future. |
Shinigami92
reviewed
Jan 27, 2023
Shinigami92
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
faker.internet.userAgent, so that every return value is equally possible. That means that the function will no longer return values based on a "real-world" distribution.I did this for multiple reasons:
Fakeris not a real-world database! We provide data which is reasonable. It is not our goal to mirrow the real world in all tiny details.For example: In Germany, the last name "Müller" is super popular, yet it has the same return probability as any other last name in the German locale dataset.
Could be seen as a fix for #216.