Skip to content

fix(V6): nested selection 🔧 fix canvas exporting 🧩 #7893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 115 commits into from
Closed

fix(V6): nested selection 🔧 fix canvas exporting 🧩 #7893

wants to merge 115 commits into from

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Apr 20, 2022 •
edited
Loading

Gist

Solves an edge case for #7882.

Group doesn't render selected objects if preserveObjectStacking is false. This poses a problem when calling isTargetTransparent and toCanvasElement.
This PR solves these cases.

  • the rendering cycle now passes a context object that can be used for various cases. Very useful. I needed it to inform group to render itself with all its objects. This is used by isTargetTransparent and toCanvasElement and even enhances the filter option of toCanvasElement that is now deep.
  • adapted logic
  • added tests

View the diff

ShaMan123 added 30 commits April 3, 2022 23:32
@ShaMan123
apply 7744 patch (no binaries)
1a191a7
@ShaMan123
apply 7744 patch (binaries)
26e8392
@ShaMan123
commit #7744 review
7d793b3 
#7744 (review)
@ShaMan123
patch2
2708029
@ShaMan123
Update spray_brush.class.js
02a8ffa
@ShaMan123
enable text editing under group
0d3690f
@ShaMan123
migrate back to isDescendantOf
ff0346a
@ShaMan123
render bg
812f02a
@ShaMan123
fix(): clear canvas from entire object tree
053946c 
in case object is a collection
@ShaMan123
fix(): center object in case object is nested
db76c44
@ShaMan123
Update eraser_brush.mixin.js
04aad5b
@ShaMan123
Update canvas.class.js
8c1c535
@ShaMan123
Update canvas_events.mixin.js
3fd4af2
@ShaMan123
lint
58e9be2
@ShaMan123
safeguard from adding group to itself
c2ef2f5
@ShaMan123
Update object_ancestry.mixin.js
f0145b5
@ShaMan123
patch tests from v6!
cb20b81
@ShaMan123
Update canvas_grouping.mixin.js
347f80d
@ShaMan123
Update canvas.class.js
a56d55e
@ShaMan123
Update group_layout.js
2a426e7
@ShaMan123
Update group_layout.js
5e3fc1f
@ShaMan123
remove redundant logic
2b1f680
@ShaMan123
Update canvas_grouping.mixin.js
1ad5cc8
@ShaMan123
fix(): calling sendPointToPlane
11c828f
@ShaMan123
Update group.class.js
b6fa3dc
@ShaMan123
refactor enterGroup
e9afc89
@ShaMan123
invalidate groups after active selection change
d8f8251
@ShaMan123
_shouldSetNestedCoords
c58a274
@ShaMan123
perf(): refrain from contains
c0f5571
@ShaMan123
Update canvas_events.mixin.js
9a223d0
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.14 |    76.14 |   85.57 |   82.87 |                                               
 fabric.js |   83.14 |    76.14 |   85.57 |   82.87 | ...,30889,30963,30974-31039,31162,31261,31497 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123
don't limit check to group
c0cd396 
important for custom objects
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.14 |    76.14 |   85.57 |   82.87 |                                               
 fabric.js |   83.14 |    76.14 |   85.57 |   82.87 | ...,30889,30963,30974-31039,31162,31261,31497 
-----------|---------|----------|---------|---------|-----------------------------------------------

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.14 |    76.14 |   85.57 |   82.87 |                                               
 fabric.js |   83.14 |    76.14 |   85.57 |   82.87 | ...,30889,30963,30974-31039,31162,31261,31497 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.14 |    76.16 |   85.57 |   82.87 |                                               
 fabric.js |   83.14 |    76.16 |   85.57 |   82.87 | ...,30889,30963,30974-31039,31162,31261,31497 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.14 |    76.16 |   85.57 |   82.87 |                                               
 fabric.js |   83.14 |    76.16 |   85.57 |   82.87 | ...,30889,30963,30974-31039,31162,31261,31497 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.11 |    76.13 |   85.57 |   82.83 |                                               
 fabric.js |   83.11 |    76.13 |   85.57 |   82.83 | ...,30915,30989,31000-31065,31188,31287,31523 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123
ShaMan123 commented May 1, 2022
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated from #7882

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.15 |    76.21 |   85.56 |   82.87 |                                               
 fabric.js |   83.15 |    76.21 |   85.56 |   82.87 | ...,30924,30998,31009-31074,31197,31296,31532 
-----------|---------|----------|---------|---------|-----------------------------------------------

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jun 12, 2022
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Jun 13, 2022
@stale
Copy link

stale bot commented Jun 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jun 28, 2022
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Jun 28, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jul 30, 2022
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Aug 1, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Sep 21, 2022
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Sep 21, 2022
@asturur asturur removed the group label Jan 14, 2024
@asturur asturur closed this Jan 14, 2024
@asturur asturur mentioned this pull request Jan 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur