feat(Object Stacking): 🔙 refactor logic to support Group 🔝 #7877

ShaMan123 · 2022-04-15T04:32:58Z

Refactored logic to support object stacking operations on Group by moving relevant logic from StaticCanvas to Collection.
Renamed methods to enable the following:

group.sendToBack();   // will send group to back in it's parent
group.sendObjectToBack(group.item(5));   // will move the object at index 5 to index 0

I think we should remove object stacking methods (src/mixins/object_stacking.mixin.js) from Object. What happens when an object is part of ActiveSelection and an object stacking method is called on it is strange and confusing.
Consider the following:

let obj, canvas;
canvas.getActiveObject().item(0) === obj //   true
canvas.getActiveObject().item(0).bringToFront()  // mutates canvas' stack
canvas.getActiveObject().item(0) === obj //   true

With this PR the dev can achieve the following:

obj.bringToFront() // acts on the origin stack manager, not on the ActiveSelection 
canvas.getActiveObject().bringObjectToFront(obj) // acts on the ActiveSelection

Should we drop object stacking methods on Object and have the dev decide which stack to mutate?

canvas.getActiveObject().bringObjectToFront(obj)
// in case obj is part of some group and is in active selection it's group prop is overridden by the ActiveSelection
// parent is canvas or group, not AS
obj.getParent().bringObjectToFront(obj)

BREAKING

canvas object stacking methods were renamed (sendToBack -> sendObjectToBack etc.)

can't wait for proper typescript!!!!!

github-actions · 2022-04-15T04:34:57Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.88 |    75.35 |   86.23 |   82.59 |                                               
 fabric.js |   82.88 |    75.35 |   86.23 |   82.59 | ...,30574,30648,30659-30724,30847,30946,31182 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-04-15T04:41:43Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.87 |    75.32 |   86.23 |   82.58 |                                               
 fabric.js |   82.87 |    75.32 |   86.23 |   82.58 | ...,30574,30648,30659-30724,30847,30946,31182 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-04-15T05:47:59Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.98 |    75.52 |   86.36 |   82.69 |                                               
 fabric.js |   82.98 |    75.52 |   86.36 |   82.69 | ...,30578,30652,30663-30728,30851,30950,31186 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-04-15T06:01:57Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.93 |    75.49 |   86.36 |   82.64 |                                               
 fabric.js |   82.93 |    75.49 |   86.36 |   82.64 | ...,30578,30652,30663-30728,30851,30950,31186 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-04-15T08:07:29Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.93 |    75.49 |   86.36 |   82.64 |                                               
 fabric.js |   82.93 |    75.49 |   86.36 |   82.64 | ...,30578,30652,30663-30728,30851,30950,31186 
-----------|---------|----------|---------|---------|-----------------------------------------------

will probably cause merge conflict

github-actions · 2022-04-15T10:01:42Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.93 |    75.48 |   86.36 |   82.64 |                                               
 fabric.js |   82.93 |    75.48 |   86.36 |   82.64 | ...,30581,30655,30666-30731,30854,30953,31189 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-05-01T16:18:30Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.08 |    76.09 |    85.8 |    82.8 |                                               
 fabric.js |   83.08 |    76.09 |    85.8 |    82.8 | ...,30970,31044,31055-31120,31243,31342,31578 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123

updated from master

github-actions · 2022-05-02T10:34:01Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.09 |    76.12 |   85.79 |   82.81 |                                               
 fabric.js |   83.09 |    76.12 |   85.79 |   82.81 | ...,30979,31053,31064-31129,31252,31351,31587 
-----------|---------|----------|---------|---------|-----------------------------------------------

stale · 2022-06-12T12:56:06Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2022-06-13T06:26:14Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.11 |    76.14 |   85.86 |   82.84 |                                               
 fabric.js |   83.11 |    76.14 |   85.86 |   82.84 | ...,30989,31063,31074-31139,31262,31361,31597 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-16T11:50:51Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.2 |    76.26 |   85.88 |   82.94 |                                               
 fabric.js |    83.2 |    76.26 |   85.88 |   82.94 | ...,30972,31046,31057-31122,31245,31344,31580 
-----------|---------|----------|---------|---------|-----------------------------------------------

stale · 2022-07-10T05:27:09Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2022-07-30T19:18:12Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2022-09-21T02:40:44Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ShaMan123 · 2022-11-23T07:44:18Z

This PR will be ported to the collection-stacking branch.

ShaMan123 added 9 commits April 14, 2022 10:43

chore(): move object stacking logic to collection

f5a4f89

expose stack methods on group

4a487f8

Update collection.mixin.js

55378a8

Update build.js

799a1c3

remove callSuper - broken with Collection

8437e8b

can't wait for proper typescript!!!!!

rename

38aabae

fix(): disable active selection imperative stack changes

593fd6f

renaming + _getStackManager

9bdab30

Update object_stacking.mixin.js

08c917b

ShaMan123 added the group label Apr 15, 2022

Update object_stacking.mixin.js

1754f37

ShaMan123 added 3 commits April 15, 2022 08:40

better checks

d72398f

Update object_stacking.mixin.js

be4a257

Update group.js

018ad2e

ShaMan123 mentioned this pull request Apr 15, 2022

V6: 🎉 Group Rewrite #7670

Closed

48 tasks

ShaMan123 changed the title ~~feat(Object Stacking): refactor logic to support Group~~ feat(Object Stacking): 🔙 refactor logic to support Group 🔝 Apr 15, 2022

ShaMan123 added 2 commits April 15, 2022 12:59

port from patch7

0a151bf

will probably cause merge conflict

Update object_stacking.mixin.js

65efc2b

stale bot added the stale Issue marked as stale by the stale bot label Apr 29, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Apr 30, 2022

fabricjs deleted a comment from stale bot May 1, 2022

ShaMan123 added 2 commits May 1, 2022 19:15

Update object_ancestry.mixin.js

88fb82e

Merge branch 'master' into object-stacking-to-collection

88205a7

ShaMan123 commented May 1, 2022

View reviewed changes

Merge branch 'master' into object-stacking-to-collection

642a487

stale bot added the stale Issue marked as stale by the stale bot label Jun 12, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Jun 13, 2022

Merge branch 'master' into object-stacking-to-collection

7a1820e

Merge branch 'master' into object-stacking-to-collection

7db65d0

stale bot added the stale Issue marked as stale by the stale bot label Jul 10, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Jul 10, 2022

stale bot added the stale Issue marked as stale by the stale bot label Jul 30, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Aug 1, 2022

stale bot added the stale Issue marked as stale by the stale bot label Sep 21, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Sep 21, 2022

ShaMan123 mentioned this pull request Nov 23, 2022

BREAKING(Object Stacking): 🔙 refactor logic to support Group 🔝 #8461

Merged

asturur closed this in #8461 Dec 29, 2022

ShaMan123 deleted the object-stacking-to-collection branch February 5, 2023 05:43

Uh oh!

feat(Object Stacking): 🔙 refactor logic to support Group 🔝 #7877

feat(Object Stacking): 🔙 refactor logic to support Group 🔝 #7877

Uh oh!

Conversation

ShaMan123 commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BREAKING

Uh oh!

github-actions bot commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

github-actions bot commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

github-actions bot commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

github-actions bot commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

github-actions bot commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

github-actions bot commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

github-actions bot commented May 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

ShaMan123 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

stale bot commented Jun 12, 2022

Uh oh!

github-actions bot commented Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

github-actions bot commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

stale bot commented Jul 10, 2022

Uh oh!

stale bot commented Jul 30, 2022

Uh oh!

stale bot commented Sep 21, 2022

Uh oh!

ShaMan123 commented Nov 23, 2022

Uh oh!

Uh oh!

ShaMan123 commented Apr 15, 2022 •

edited

Loading

github-actions bot commented Apr 15, 2022 •

edited

Loading

github-actions bot commented Apr 15, 2022 •

edited

Loading

github-actions bot commented Apr 15, 2022 •

edited

Loading

github-actions bot commented Apr 15, 2022 •

edited

Loading

github-actions bot commented Apr 15, 2022 •

edited

Loading

github-actions bot commented Apr 15, 2022 •

edited

Loading

github-actions bot commented May 1, 2022 •

edited

Loading

github-actions bot commented May 2, 2022 •

edited

Loading

github-actions bot commented Jun 13, 2022 •

edited

Loading

github-actions bot commented Jun 16, 2022 •

edited

Loading