Skip to content

fix(SVGImport): Allow for correct style element parsing #10688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

fix(SVGImport): Allow for correct style element parsing #10688

merged 2 commits into from
Jul 21, 2025

Conversation

asturur
Copy link
Member

@asturur asturur commented Jul 21, 2025 •
edited
Loading

backport #10683

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jul 21, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 931.625 (-0.033) 308.533 (-0.014)

@github-actions GitHub Actions
Copy link
Contributor

Coverage after merging v671 into 6.x will be

86.65%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
fabric.ts86.92%20%0%95.79%10, 144, 144, 144, 144, 144, 190, 190, 190, 190, 190, 31, 33, 33, 33, 33, 33–34, 34, 34, 34, 34, 39, 8
index.node.ts14.29%100%0%25%23, 26, 29, 41, 44, 47
extensions/aligning_guidelines/util
   basic.ts100%100%100%100%
extensions/data_updaters/origins
   index.ts97.50%75%100%100%22–23
src
   ClassRegistry.ts92.54%69.23%100%97.92%35, 56
   Collection.ts81.69%55.77%87.10%86.21%130, 153, 155–157, 159, 169–170, 181, 197, 217, 228, 241, 243, 252, 254, 265, 270, 279, 281, 286–287, 302, 304, 309–310, 329, 333–334, 338–344, 346–348, 350
   CommonMethods.ts92.75%76.92%100%96%50, 52
   EventTypeDefs.ts100%100%100%100%
   Intersection.ts86.19%51.14%100%97.30%184–188, 190, 228, 237, 239, 289, 297, 297
   Observable.ts83.24%62.16%93.75%87.88%144, 153, 156, 168, 170, 175, 68–70, 72, 76, 80, 84–85, 87–91
   Point.ts90.53%62%100%93.90%104, 117, 148, 157, 179, 197, 206, 216, 225, 236–239, 259, 285, 297, 328, 341, 349, 359, 95
   Shadow.ts89.08%75%100%90%140, 143, 145–150, 159, 196, 199, 206, 223–230, 234–235
   cache.ts87.95%62.50%100%90.14%57, 59, 71–72, 74–77
   config.ts88.02%55%66.67%94.20%136, 138–141, 143, 146–147, 151, 156
   constants.ts100%100%100%100%
   typedefs.ts100%100%100%100%
src/LayoutManager
   ActiveSelectionLayoutManager.ts93.33%76.92%85.71%100%
   LayoutManager.ts91.90%69.62%76.92%99.31%279, 344, 355
   constants.ts100%100%100%100%
   index.ts48.57%37.50%80%66.67%1, 1, 1–2, 2, 2–3, 3, 3–4, 4, 4–5, 5, 5, 5–6
   types.ts100%100%100%100%
src/LayoutManager/LayoutStrategies
   ClipPathLayout.ts76%60%100%78.95%39, 41–44, 46–48, 66–69
   FitContentLayout.ts100%100%100%100%
   FixedLayout.ts85.71%20%100%100%23, 23
   LayoutStrategy.ts91.53%68%100%97.67%54, 73, 75
   utils.ts72.58%50%100%78.72%29–32, 34–35, 40–44
src/Pattern
   Pattern.ts67.36%88.24%80%63.08%105–107, 114, 118–119, 119–122, 130–138, 140–141, 143, 153–164, 174, 176–181, 183–188, 190–199, 203–206, 209–210, 212–214, 216–218, 218–221, 33, 37
   index.ts50%100%100%50%2
   types.ts100%100%100%100%
src/brushes
   BaseBrush.ts89.26%90.91%100%88.55%110, 115, 124–125, 130, 135, 143, 146, 155–160, 99
   CircleBrush.ts52.54%14.29%12.50%58.25%100–108, 108–118, 122, 130–139, 55, 67, 69, 76, 76, 78–79, 79, 83, 85–86, 92–98
   PatternBrush.ts75%100%100%69.64%25–31, 34, 36, 44, 54, 62, 64–67, 69
   PencilBrush.ts76.36%78.38%100%74.44%116, 122, 124, 129, 139, 147–149, 151–152, 152, 155, 158, 169, 176, 176, 181–184, 189, 191, 193–194, 198–201, 205, 215, 224–231, 235–236, 238, 246, 248, 255–256, 260–263, 266, 278, 280–288, 296–297, 299, 68, 84
   SprayBrush.ts52.25%0%0%58.86%100, 107, 107, 107, 107–112, 118–120, 122, 128–135, 137–139, 141, 141, 141–148, 148, 152, 157, 162, 164, 169–170, 172, 180, 182, 185, 187, 195, 198–200, 200, 200–207, 207, 207–210, 212, 22, 67, 85–87, 94–99
   typedefs.ts100%100%100%100%
src/canvas
   Canvas.ts83.18%53.10%98.21%90.95%1001–1005, 1031–1034, 1037, 1045–1046, 1050–1051, 1102–1107, 1160, 1163, 1167, 1174, 1177, 1240–1244, 1323, 1323–1327, 1351, 1351, 1354, 1424, 1435, 1440–1445, 1448–1449, 1451, 1455, 1457–1458, 1460–1462, 1466, 1469, 1504, 1511, 1513–1524, 1526–1529, 1529–1530, 1532–1533, 1537–1538, 1541–1542, 1545–1547, 1550, 339, 364, 380, 399, 454, 558, 575, 577, 580–581, 583, 593, 596, 599–600, 623–624, 642, 688, 690, 708, 710, 712–713, 715–718, 776, 814–815, 818, 827, 853, 915–916, 968, 981, 984–989, 992
   CanvasOptions.ts100%100%100%100%
   SelectableCanvas.ts88.87%64.91%100%94.67%1006, 1008–1009, 1026, 1035, 1153–1154, 1156–1157, 1159, 1186, 1188–1189, 1189, 1191, 1233, 1235, 1237, 1253, 1255, 1259, 1262, 1283, 1286, 1329–1336, 1339, 1342, 1351–1352, 1356–1365, 1369, 1371–1372, 1378–1383, 1387, 340–342, 346, 376, 398, 476, 527, 529, 605, 610, 687, 715
   StaticCanvas.ts76.80%67.56%97.85%76.90%1001, 1007, 1010, 1012, 1014, 1022, 1024–1030, 1040, 1046–1052, 1054–1055, 1057–1078, 1085–1087, 1089, 1097, 1103, 1105, 1105–1106, 1106–1107, 1109, 1109–1114, 1127, 1132–1134, 1138, 1142, 1144, 1146, 1151–1155, 1157, 1159–1162, 1165, 1167, 1176, 1178–1179, 1186–1189

@asturur asturur merged commit c1f43f6 into 6.x Jul 21, 2025
20 checks passed
@asturur asturur deleted the v671 branch July 21, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asturur @Chicken-3001