chore(tests): replace unmaintained http-server with vercels serve #10603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http-server had no release for 3 years now and outputs a warnings when ran like ```text [WebServer] (node:3503) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated [WebServer] (Use `node --trace-deprecation ...` to show where the warning was created) ``` which is annoying we are better off with something more modern and properly maintained. There is also a way to not use http server at all for playwright but just intercept the routes via route handlers and autorespond with files from filesystem. That would avoid dependency on http server completely and would be faster in theory.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Build Stats
|
|
i think i should write an action that on merge conflicts for changelog.md solve the conflicts. |
asturur
approved these changes
May 17, 2025
|
I agree because this is GENERALLY SPEAKING best practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http-server had no release for 3 years now and outputs a warnings when ran like
which is annoying
we are better off with something more modern and properly maintained.
There is also a way to not use http server at all for playwright but just intercept the routes via route handlers and autorespond with files from filesystem.
That would avoid dependency on http server completely and would be faster in theory.