refactor(tests): migrate object tests to vitest #10562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Smrtnyk
commented
Apr 20, 2025
| @@ -734,7 +734,7 @@ export class FabricObject< | |||
| */ | |||
| hasStroke() { | |||
| return ( | |||
| this.stroke && this.stroke !== 'transparent' && this.strokeWidth !== 0 | |||
| !!this.stroke && this.stroke !== 'transparent' && this.strokeWidth !== 0 | |||
There was a problem hiding this comment.
without this it would return empty string
although "falsy" it is not a boolean
qunit was testing this loosely treating empty string as false
but vitest is bit more strict and precise here
There was a problem hiding this comment.
the intention of this is to be a boolean, can you add it to the typo of hasStroke explicitly?
There was a problem hiding this comment.
You mean to add :boolean as return type of this method?
|
ok update changelog seem to work finally |
|
Build Stats
|
|
asturur
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.