Skip to content

Chore() more qunit post cleanup #10569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2025
Merged

Chore() more qunit post cleanup #10569

merged 3 commits into from
Apr 21, 2025

Conversation

Smrtnyk
Copy link
Contributor

@Smrtnyk Smrtnyk commented Apr 21, 2025 •
edited
Loading

removed two npm scripts because they seem obsolete now

Is cli tool for test still used @asturur ?
It still shows 2 options for visual and unit tests in qunit

I also removed the bithoundrc file since that service is dead for years now

Smrtnyk added 2 commits April 21, 2025 19:31
@Smrtnyk
chore(): more qunit post cleanup
b7a5b72 
 Removes two scripts that seem obsolete now
@Smrtnyk
chore(): more qunit post cleanup
90a418d 
 Remove bithoundrc
@codesandbox CodeSandbox
Copy link

codesandbox bot commented Apr 21, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 913.867 (0) 301.234 (0)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025 •
edited
Loading 


> fabric@6.6.2 coverage:report:ci
> nyc report --reporter=text-summary


=============================== Coverage summary ===============================
Statements   : 73.91% ( 21243/28739 )
Branches     : 61.86% ( 4308/6963 )
Functions    : 85.42% ( 1541/1804 )
Lines        : 80.21% ( 16617/20715 )
================================================================================

@Smrtnyk Smrtnyk closed this Apr 21, 2025
@Smrtnyk Smrtnyk reopened this Apr 21, 2025
@asturur
Copy link
Member

asturur commented Apr 21, 2025

i used the cli tool for unit test a lot, and i would still use it for visual till they are there.

@asturur asturur merged commit 97437ed into fabricjs:master Apr 21, 2025
16 checks passed
@Smrtnyk
Copy link
Contributor Author

Smrtnyk commented Apr 21, 2025

i used the cli tool for unit test a lot, and i would still use it for visual till they are there.

I started looking a bit into visual tests in how they work
lets see how long it will take me to completely understand the whole concept so I am ready to start porting them

@Smrtnyk Smrtnyk deleted the chore()-more-qunit-post-cleanup branch May 9, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smrtnyk @asturur