Skip to content

chore(): update vitest #10565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2025
Merged

chore(): update vitest #10565

merged 4 commits into from
Apr 21, 2025

Conversation

Smrtnyk
Copy link
Contributor

@Smrtnyk Smrtnyk commented Apr 21, 2025

There are many improvements and fixes in this release

@Smrtnyk
chore(): update vitest
676d34c 
 There are many improvements and fixes in this release
@codesandbox CodeSandbox
Copy link

codesandbox bot commented Apr 21, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 913.867 (0) 301.234 (0)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025 •
edited
Loading 


> fabric@6.6.2 coverage:report:ci
> nyc report --reporter=text-summary


=============================== Coverage summary ===============================
Statements   : 73.91% ( 21243/28739 )
Branches     : 61.88% ( 4309/6963 )
Functions    : 85.42% ( 1541/1804 )
Lines        : 80.21% ( 16617/20715 )
================================================================================

@Smrtnyk
Copy link
Contributor Author

Smrtnyk commented Apr 21, 2025

I have chromium unit tests in vitest working locally
just need a bit of cleanup and will open a PR soon

@asturur
Copy link
Member

asturur commented Apr 21, 2025

I have chromium unit tests in vitest working locally just need a bit of cleanup and will open a PR soon

this could tame more to review/discuss

@asturur asturur merged commit 294e63f into fabricjs:master Apr 21, 2025
15 checks passed
@Smrtnyk
Copy link
Contributor Author

Smrtnyk commented Apr 21, 2025

I have chromium unit tests in vitest working locally just need a bit of cleanup and will open a PR soon

this could tame more to review/discuss

I will open a PR, it is with minimal changes since almost all tests work just fine in both jsdom and chromium
and then you can decide if you want it or not

@Smrtnyk Smrtnyk deleted the chore()-update-vitest branch April 21, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smrtnyk @asturur