refactor(tests): move object interactivity tests from qunit to vitest #10554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Smrtnyk
commented
Apr 19, 2025
| @@ -282,8 +282,8 @@ export class Control { | |||
| */ | |||
| setVisibility( | |||
| visibility: boolean, | |||
| name: string, | |||
| fabricObject: InteractiveFabricObject, | |||
| name?: string, | |||
There was a problem hiding this comment.
not sure what these are about
they seem unused in code
also tests didn't provide them, so I just made them optional to fix type issues in tests
should these actually be removed from the function signature?
There was a problem hiding this comment.
This was there to set an api. If you would override the Control class to be smarter, you could write different logic depending on what control was doing on which object.
I don't think anyone ever used it, but also there is no reason to remove it right now.
|
Build Stats
|
|
asturur
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.