Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

I wanted to do this, but when i heard that the new version is written in go and is 10x faster i just wanted to wait.
But since you made the work, let's move on

i hoped TS would grow with better understanding rather than poorer.
Destructuring is one of the nice modern JS syntaxes, and that promise there can return either undefined or that exact type, i don't understand why it doesn't accept it.

I wanted to do this, but when i heard that the new version is written in go and is 10x faster i just wanted to wait. But since you made the work, let's move on

that will take a while unfortunately
strada is scheduled for end of the year I think

i hoped TS would grow with better understanding rather than poorer. Destructuring is one of the nice modern JS syntaxes, and that promise there can return either undefined or that exact type, i don't understand why it doesn't accept it.

I understand what you mean, but it is the best we get currently in js world
I am sure after they migrate to strada and ts go is the new default they will resume on improving the language and making it better

you would think you made it at this point.
nope.

i hoped TS would grow with better understanding rather than poorer. Destructuring is one of the nice modern JS syntaxes, and that promise there can return either undefined or that exact type, i don't understand why it doesn't accept it.

I understand what you mean, but it is the best we get currently in js world I am sure after they migrate to strada and ts go is the new default they will resume on improving the language and making it better

Is not bad at all, is just a bit less smarter than i expected

There are a bunch of TS-NOCHECK or TS-IGNORE around the codebase that will need to be re-evaluated to understand if TS offers a way to fix them

There are a bunch of TS-NOCHECK or TS-IGNORE around the codebase that will need to be re-evaluated to understand if TS offers a way to fix them

I plan to finish migration of qunit to vitest and also visual to playwright
then I could have a look at typescript

There are a bunch of TS-NOCHECK or TS-IGNORE around the codebase that will need to be re-evaluated to understand if TS offers a way to fix them

I plan to finish migration of qunit to vitest and also visual to playwright then I could have a look at typescript

Yes i wan't asking you to do so, just to inform that ususally when i bump i go and i look for solutions to old problems to see if they have been included. Is how i learn.

For the visual tests there is already a framework is just a matter of moving the functions, i started already but i m not sure of long term stability

i m finishing the actions from forks so they all pass, i ll finish my gradient PR and i ll update the website to handle versioned docs in someway, you don't have to do all the tests if you get bored stop

There are a bunch of TS-NOCHECK or TS-IGNORE around the codebase that will need to be re-evaluated to understand if TS offers a way to fix them

I plan to finish migration of qunit to vitest and also visual to playwright then I could have a look at typescript

Yes i wan't asking you to do so, just to inform that ususally when i bump i go and i look for solutions to old problems to see if they have been included. Is how i learn.

For the visual tests there is already a framework is just a matter of moving the functions, i started already but i m not sure of long term stability

i m finishing the actions from forks so they all pass, i ll finish my gradient PR and i ll update the website to handle versioned docs in someway, you don't have to do all the tests if you get bored stop

no worries, I am not a maths guy so I can't really help much with fabrics source code
but with tests I have experience
also moving to vitest is easy and straight forward, just a bit of manual work but it is not a big deal
playwright will be more interesting part
I already started studying the current playwright setup and opened a PR to simplify it a bit.
The reason I want to help is that I am using fabric for my personal project and also I would like you to have more time to focus on actual fabric features and bugfixes so that project can move forward with the time