refactor(tests): move observable tests from qunit to vitest #10501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Smrtnyk
commented
Apr 7, 2025
|
|
||
| expect( | ||
| // @ts-expect-error -- private method | ||
| foo.__eventListeners['bar:baz'].length, |
There was a problem hiding this comment.
I am not really a fan of testing implementation details like private methods and members
but this is just a migration from qunit to vitest
I guess if you want you can think of better approach in the future in case you care about this
There was a problem hiding this comment.
There are so many things to do, that having test coverage and early catching unwanted changes is already good enough for me. Some tests written for qunit 10 years ago seem silly now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this moves observable tests from qunit to vitest
this one is pretty straight forward move