Skip to content

ci(): Avoid failure status when the intent is to comment #10508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

ci(): Avoid failure status when the intent is to comment #10508

merged 3 commits into from
Apr 10, 2025

Conversation

asturur
Copy link
Member

@asturur asturur commented Apr 10, 2025

No description provided.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Apr 10, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 917.110 (0) 301.920 (0)

@asturur asturur merged commit 853b161 into master Apr 10, 2025
22 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Coverage after merging avoid-failing-when-we-need-to-warn into master will be

46.77%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
eslint.config.mjs0%0%0%0%1, 1, 10, 100–108, 11–14, 16–19, 2, 20–29, 3, 30–32, 34–39, 4, 40–45, 47–49, 5, 50–51, 53–59, 6, 60–63, 65–79, 8, 80–85, 87, 89, 9, 90–94, 96–99
fabric.ts100%100%100%100%
index.node.ts6.45%100%100%0%11, 15, 17, 19, 21–29, 3, 30–31, 39, 4, 40–49, 6
index.ts0%0%0%0%1, 1
playwright.config.ts3.92%100%100%0%10, 12–13, 18–19, 2, 20–23, 25, 27, 29, 31, 33, 35, 37–42, 44, 46, 48, 51–55, 58–66, 69, 7, 70–75, 77, 8
playwright.setup.ts0%0%0%0%1, 1, 11–12, 14–15, 17–28, 3, 30–32, 34–39, 4, 40–43, 45–49, 5, 50–55, 57–59, 6, 61–70, 73–79, 8, 80–84, 9
publish-next.js0%0%0%0%1, 1, 11, 13, 15, 3, 5, 7, 9
publish.js0%0%0%0%1, 1, 10, 12, 14–15, 17, 3–4, 6–9
rollup.config.mjs0%0%0%0%1, 1, 100–109, 11, 110–129, 13, 130–139, 14, 140–149, 15, 150–151, 153–159, 16, 160–169, 17, 170–179, 18, 180, 19, 2, 20–26, 28–29, 3, 30–39, 4, 41–49, 5, 50–59, 6, 60–61, 63–69, 7, 70–89, 9, 90–99
rollup.test.config.js0%0%0%0%1, 1, 10–19, 2, 20–24, 4, 6–9
vitest.config.ts0%0%0%0%1, 1, 10–22, 3–9
.codesandbox
   deploy.mjs0%0%0%0%1, 1, 10, 100–103, 105–109, 11, 110, 12, 14–16, 18–19, 2, 20–22, 24–29, 3, 30–31, 33–39, 4, 40–49, 5, 50–51, 53–59, 6, 60–79, 8, 80–98
   start.mjs0%0%0%0%1, 1, 10–19, 2, 20–22, 24–29, 3, 30, 32–35, 37–39, 4, 40–49, 5, 50–51, 53–59, 6, 61–65, 67–69, 7, 70–72, 8
.codesandbox/templates/next
   next.config.mjs0%0%0%0%1, 1–6, 8
.codesandbox/templates/next/components
   Canvas.tsx0%0%0%0%1, 1, 10, 13–14, 16–19, 2, 21, 23, 25–29, 33, 35–36, 38–39, 4, 40–42, 48–50, 52–53
.codesandbox/templates/next/pages
   _app.tsx0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 31–37, 39, 4, 40–44, 46–49, 5, 50–52, 54–59, 6, 60–61, 63, 7, 9
   _document.tsx0%0%0%0%1, 1, 10–14, 16, 3–9
   index.tsx0%0%0%0%1, 1, 10–29, 3, 30–35, 37–39, 4, 40–53, 55–58, 6, 60, 62, 7, 9
   node.tsx6.06%100%100%0%10–15, 17–19, 2, 20–29, 3, 31–33, 35, 37, 4, 6–9
.codesandbox/templates/next/pages/api
   fabric.ts11.76%100%100%0%10–17, 2, 4–9
.codesandbox/templates/node/src
   index.mjs0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–32, 5, 7–9
.codesandbox/templates/vanilla/src
   index.ts0%0%0%0%1, 1, 10, 12, 2–3, 5–9
.codesandbox/templates/vanilla/src/testcases
   activeSelectionOrigin.ts0%0%0%0%1, 1, 10–29, 3, 31–39, 4, 40–50, 52–59, 6, 60–69, 7, 70, 72–78, 9
   clearCache.ts0%0%0%0%1, 1, 10–12, 14–17, 19–20, 22–23, 3–7, 9
   clipPathSelection.ts0%0%0%0%1, 1, 10–24, 26–29, 3, 30–32, 34–38, 4, 40, 42–48, 5, 50–60, 62, 64, 66–69, 7, 70, 9
   filters.ts0%0%0%0%1, 1, 10–29, 3, 30–39, 4, 40–48, 5–9
   fixedLayoutGroup.ts0%0%0%0%1, 1, 10, 100–103, 11–29, 3, 30–33, 35–36, 38–39, 4, 40–45, 47–49, 5, 50–54, 56–59, 6, 60–63, 65–69, 7, 71, 73–79, 8, 80–89, 9, 90–95, 97, 99
   flippedInteractive.ts0%0%0%0%1, 1, 10–17, 19–28, 3, 30, 32–35, 37–39, 4, 40–46, 48–59, 6, 60–69, 7–9
   guidelines.ts0%0%0%0%1, 1, 10–11, 13–14, 2, 4–8
   loadingSvgs.ts0%0%0%0%1, 1, 21–24, 3
   nestedSelections.ts0%0%0%0%1, 1, 10, 100–101, 11–29, 3, 30–39, <

@asturur asturur deleted the avoid-failing-when-we-need-to-warn branch April 10, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asturur