chore(): dependencies maintenance #10497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Smrtnyk
commented
Apr 7, 2025
| @@ -81,32 +81,30 @@ | |||
| "@types/fs-extra": "^9.0.13", | |||
| "@types/jsdom": "^20.0.1", | |||
| "@types/lodash": "^4.14.180", | |||
| "@types/mocha": "^10.0.1", | |||
| "@types/micromatch": "^4.0.9", | |||
There was a problem hiding this comment.
these types were missing
Smrtnyk
commented
Apr 7, 2025
| import match from 'micromatch'; | ||
| import path from 'path'; | ||
| import { makeRe } from 'micromatch'; | ||
| import * as path from 'node:path'; |
There was a problem hiding this comment.
these were lint errors now that this file is properly linted
Smrtnyk
commented
Apr 7, 2025
| @@ -43,8 +43,8 @@ export type SerializedLayoutManager = { | |||
| }; | |||
|
|
|||
| export class LayoutManager { | |||
| private declare _prevLayoutStrategy?: LayoutStrategy; | |||
| protected declare _subscriptions: Map<FabricObject, VoidFunction[]>; | |||
| declare private _prevLayoutStrategy?: LayoutStrategy; | |||
There was a problem hiding this comment.
these are from newer prettier just reordering these
Smrtnyk
commented
Apr 7, 2025
| @@ -3,4 +3,4 @@ export * from './LayoutStrategies/ClipPathLayout'; | |||
| export * from './LayoutStrategies/FitContentLayout'; | |||
| export * from './LayoutStrategies/FixedLayout'; | |||
| export * from './LayoutStrategies/LayoutStrategy'; | |||
| export * from './types'; | |||
| export type * from './types'; | |||
There was a problem hiding this comment.
newer eslint prefers that type only exports are marked as such
There was a problem hiding this comment.
yes that is good anyway for rollup to know and any builder
6fd63a1 to
3520faa
Compare
asturur
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some dependencies maintenance like updating lint related ones.
There were some new prettier issues which are fixed now and also eslint ones regarding exporting of types which are also fixed now.
Also updated micromatch because it reported security vulnerability.
included playwright setup file in lint now as well so it is properly linted.
Removed few deps that I think are unused but lets see what CI says.
I tried to analyse what is babel doing in playwright setup file, seems like there is some kind of a watcher built into playwright tests, but I can't see where is the watch used at all?
is it when tests are failing so it is triggered again on changes?
Is that watch mechanism needed at all for playwright?
Seems like a lot of acrobatics and overhead but maybe I misinterpreted it