ci(): update playwright #10496
Merged
ci(): update playwright #10496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Smrtnyk
commented
Apr 6, 2025
| @@ -60,7 +60,7 @@ | |||
| "test:vitest:coverage:watch": "vitest --coverage=true", | |||
| "coverage:merge": "nyc merge coveragefiles .nyc_output/merged-coverage.json", | |||
| "local-server": "http-server ./ -d=false", | |||
| "test:e2e": "npx playwright test --headed", | |||
There was a problem hiding this comment.
no need for npx if playwright is installed locally as a dev dep
There was a problem hiding this comment.
i think the point of this was to avoid installing it during all the git hub actions
There was a problem hiding this comment.
Dependency have also been cached, so this may not be necessary at all. The time was 2m before is 2m now, is ok to remove npx
|
You need to add a line in the changelog for things to pass the CI |
I will add it to the changelog, first I wanted to see if you are interested for the PR |
7a0639d to
8eb1e3f
Compare
|
Updates are always ok. if it pass the tests, is ok. |
8eb1e3f to
a87e7c8
Compare
a87e7c8 to
ccf2421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that current playwright version is 20 versions old, and what also means that it is using very old browsers.
Updating playwright always to latest is a good idea to get all the bugfixes and performance improvements + being able to test on bleeding edge browser versions