Pub-sub pattern for F#-Fable compilation #2676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddd6fea to
05828fa
Compare
|
Very nice!! Great work! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment: #2659 (comment)
This is fantastic, thanks a lot for the idea @ncave! In practicality it means Fable compilation times disappear and get diluted in F# type checking times. In most cases, Fable compilation is much faster than F# type checking so we're still constrained by that. But when compiling standalone (where F# and Fable compilation took more or less the same) we're cutting the compilation time almost in half!
Changes in FCS necessary for this are here: alfonsogarciacaro/fsharp@2a49718#diff-115ce16832f5a44cba9c8b3796afe6b06c8f41a6502466034dd5dae950d53ea1R237