Skip to content

[WIP] Witnesses for STRP resolution #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[WIP] Witnesses for STRP resolution #2108

wants to merge 8 commits into from

Conversation

alfonsogarciacaro
Copy link
Member

Fix #2104

Take advantage of the new "witness passing" feature from F# compiler to improve (or actually fix) SRTP resolution in Fable. Discussion here: dotnet/fsharp#9510 (comment)

@gitpod-io
Copy link

gitpod-io bot commented Jun 25, 2020 •
edited
Loading

@alfonsogarciacaro alfonsogarciacaro linked an issue Jul 2, 2020 that may be closed by this pull request
Witnesses #2104
Closed
@alfonsogarciacaro alfonsogarciacaro changed the base branch from next to nagareyama July 2, 2020 05:37
@alfonsogarciacaro alfonsogarciacaro mentioned this pull request Sep 15, 2020
Closed
@alfonsogarciacaro
Copy link
Member Author

alfonsogarciacaro commented Sep 15, 2020 •
edited
Loading

I've rebased this with nagareyama. I would like to focus on merging this next as witnesses are going to be a super-useful feature for Fable and we should take advantage for it in Fable 3 (better SRTP resolution, not having to inline functions from external packages). I guess it's not going to be an easy one, but if you could have a look at dotnet/fsharp#9510 (comment) @ncave to see if you can find a hint to move forward that'd be of great help! 🙏

@alfonsogarciacaro
Copy link
Member Author

Superseded by #2240

@alfonsogarciacaro alfonsogarciacaro deleted the witnesses branch December 3, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Witnesses
1 participant
@alfonsogarciacaro