Fix call to update_tree upon migration to zero causes ProgrammingErro… #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 91.10% 91.14% +0.03%
==========================================
Files 11 11
Lines 697 700 +3
==========================================
+ Hits 635 638 +3
Misses 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fabiocaccamo
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
@danilo-botelho thank you for this great PR, I jsut did some fixes to pass tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r. #188
name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo
Describe your changes
I added a table exists check to post_migrate_treenode signal handler so that it won't call update_tree if the table is not there.
Related issue
#188
Checklist before requesting a review