Skip to content

Bump up max_length of old_path/new_path from 255 to 2048. #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

voberoi
Copy link
Contributor

@voberoi voberoi commented May 2, 2025


name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes

I bumped up max_length for old_path and new_path from 255 to 2048, wrote a test for it, and added its migration.

Related issue
#124

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (e834970) to head (8e81686).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   90.50%   90.74%   +0.23%     
==========================================
  Files          10       11       +1     
  Lines         158      162       +4     
==========================================
+ Hits          143      147       +4     
  Misses         15       15              
Flag Coverage Δ
unittests 90.74% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fabiocaccamo fabiocaccamo merged commit defa864 into fabiocaccamo:main May 3, 2025
25 checks passed
@fabiocaccamo fabiocaccamo added the enhancement New feature or request label May 3, 2025
@fabiocaccamo fabiocaccamo moved this to Done in Open Source May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants