Skip to content

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Sep 5, 2023


name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes
Fix error when using image_field with RGB and RGBA formats

Related issue
Fix #153

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@browniebroke browniebroke changed the title Fix ColorField in RGB/RGBA format with image_field Fix ColorField in RGB/RGBA format with image_field Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.36% 🎉

Comparison is base (57e5f01) 88.05% compared to head (98eefc1) 88.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   88.05%   88.41%   +0.36%     
==========================================
  Files           7        7              
  Lines         159      164       +5     
==========================================
+ Hits          140      145       +5     
  Misses         19       19              
Flag Coverage Δ
unittests 88.41% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
colorfield/fields.py 91.78% <100.00%> (-0.12%) ⬇️
colorfield/utils.py 90.90% <100.00%> (+3.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocaccamo fabiocaccamo added the bug Something isn't working label Sep 5, 2023
Copy link
Owner

@fabiocaccamo fabiocaccamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again also for this PR!

@fabiocaccamo fabiocaccamo merged commit f79ae35 into fabiocaccamo:main Sep 5, 2023
@browniebroke browniebroke deleted the fix/image-field-rgb-format branch September 5, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Crash when using image_field with RGB/RGBA formats
2 participants