-
-
Notifications
You must be signed in to change notification settings - Fork 96
Add support for RGB and RGBA formats #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this great PR!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 87.16% 88.05% +0.88%
==========================================
Files 7 7
Lines 148 159 +11
==========================================
+ Hits 129 140 +11
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I think I've addressed all your suggestions, let me know if I missed anything. |
8e68f46
to
0d8e4cb
Compare
@browniebroke you can upgrade to |
Thanks for the quick release after the merge, much appreciated 🙏🏻 |
I realized just now that RGB and RGBA formats raise an error when the This happens because the color returned by |
Right... Missed that one! I'll see if I can make a quick fix, otherwise we could fallback to disable |
If you can't do it, I will do, no problem. It can be fixed quickly by passing the color format to |
name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo
Describe your changes
Add support for RGB and RGBA formats
Related issue
#84
Checklist before requesting a review