#331 Informative exit message buttons #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this message ultimately decides if we should exit without saving changes made to file, accidentlly clicking on OK instead of Cancel might cause user to loose unsaved changes. According to set theme, themes might use more appropriate theming for this dialog if we use MESSAGE_WARNING.
|
Duplicate of #313 |
Discard word is more concrete compared to OK and will convey the message of content will be forever lost if not fixed more clearly.
6826617 to
74016ec
Compare
|
Is the text in that dialog box translatable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #331.
This MR changes the exit dialog from INFORMATIONAL to WARNING type and switches the generic CANCEL_OK for more descrete and specific text "Cancel" and "Discard".