Skip to content

Extend dialog for exiting with unsaved changes #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Extend dialog for exiting with unsaved changes #313

wants to merge 1 commit into from

Conversation

justjosias
Copy link
Contributor

Resolves #308.

This is almost complete, except it behaves poorly when dealing with multiple files open at the same time.

@justjosias
Copy link
Contributor Author

Note that it gives this compile error (but it runs just fine):

../src/marker-window.c: In function ‘show_unsaved_documents_warning’:
../src/marker-window.c:135:26: warning: passing argument 1 of ‘gtk_dialog_add_buttons’ from incompatible pointer type [-Wincompatible-pointer-types]
   gtk_dialog_add_buttons(dialog,
                          ^~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtkaboutdialog.h:30,
                 from /usr/include/gtk-3.0/gtk/gtk.h:31,
                 from ../src/marker.h:25,
                 from ../src/marker-window.c:22:
/usr/include/gtk-3.0/gtk/gtkdialog.h:164:55: note: expected ‘GtkDialog *’ {aka ‘struct _GtkDialog *’} but argument is of type ‘GtkWidget
’ {aka ‘struct _GtkWidget *’}
 void       gtk_dialog_add_buttons       (GtkDialog   *dialog,
                                          ~~~~~~~~~~~~~^~~~~~

@justjosias
Copy link
Contributor Author

I am currently working on a save-all function to fix the remaining issues.

@justjosias justjosias closed this Aug 12, 2020
rohmishra
rohmishra reviewed Oct 15, 2020
View reviewed changes
src/marker-window.c
}

gtk_dialog_add_buttons(dialog,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use GTK_DIALOG to fix this as i did in #332
a926e22#diff-eb21b5e37df33cd6a3d1bc7a89cbf093dd322d54b982dcf2cf29ec37c4f1dde6R132

@rohmishra rohmishra mentioned this pull request Oct 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rohmishra rohmishra rohmishra left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Close without Saving" option
2 participants
@justjosias @rohmishra