Add support for bigints to multipleOf validation action #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for bigints in the multipleOf validation action, extending both the API and the library behavior.
- Updated type definitions in properties files to accept both number and bigint.
- Modified the internal multipleOf action implementation to use bigint where applicable and added unit tests for bigint support.
- Updated changelog to reflect the new feature.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/src/routes/api/(types)/MultipleOfIssue/properties.ts | Changed type from "number" to a union of "number" and "bigint". |
| website/src/routes/api/(types)/MultipleOfAction/properties.ts | Updated to support bigint in type definitions. |
| website/src/routes/api/(actions)/multipleOf/properties.ts | Modified to use union type for bigint support. |
| library/src/utils/_stringify/_stringify.ts | Added a TODO comment to consider appending an "n" suffix for bigints. |
| library/src/actions/multipleOf/multipleOf.ts | Updated generic constraints and modulo check to handle bigint values. |
| library/src/actions/multipleOf/multipleOf.test.ts | Added tests to validate behavior for bigint inputs. |
| library/src/actions/multipleOf/multipleOf.test-d.ts | Adjusted type inference tests to include bigint support. |
| library/CHANGELOG.md | Documented the addition of bigint support. |
commit: |
EltonLobo07
reviewed
Apr 21, 2025
EltonLobo07
reviewed
Apr 21, 2025
EltonLobo07
reviewed
Apr 21, 2025
EltonLobo07
reviewed
Apr 21, 2025
Improvements: - update the 'Related' section of related schemas & actions - fix the 'Definition' section of `MultipleOfIssue`
EltonLobo07
approved these changes
Apr 25, 2025
|
Valibot v1.1.0 is available! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1128