Fix Core Counter Accounting 2.0 #285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: D57904550 attempted to fix PerfCounterManagerHbt's core counter accounting, but fails to do so. This [check](https://www.internalfb.com/code/fbsource/[6aa310e0372997181b5ced0b7e9fcd7b746f24a5]/fbcode/dyno/cpp/server/PerfCounterManagerHbtBase.cpp?lines=222) always returns true because isMetricEnabled() returns an optional. All this does is check if the metric is contained in the monitor. Differential Revision: D61372884
|
This pull request was exported from Phabricator. Differential Revision: D61372884 |
|
This pull request has been merged in 601c4e2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: D57904550 attempted to fix PerfCounterManagerHbt's core counter accounting, but fails to do so. This check always returns true because isMetricEnabled() returns an optional. All this does is check if the metric is contained in the monitor.
Differential Revision: D61372884