Skip to content

Conversation

briancoutinho
Copy link
Contributor

Details

  1. Add hostname and refactor everyone to common function.
  2. Make prometheus-cpp a git submodule and update build scripts
  3. Add more metrics, excluding per network and per GPU metrics.
  4. Bump version.

TestPlan

Ran on my laptop using a docker container.

How to Run

Please install Docker desktop.

  1. Download this docker file in a directory https://gist.github.com/briancoutinho/c5faaa60e49a5ad796b972e6b3ef175d
  2. Build using docker build . -t prometheus:v2
  3. Run docker container forwarding port and mounting dynolog open source repo
    docker run -p 9090:9090 -it -v ~/Work/dynolog_oss/dynolog:/workspace/dynolog prometheus:v2 /bin/bash
  4. Build dynolog ./scripts/build.sh

To get the logging setup add the following in prometheus.yml

  - job_name: "dynolog"
    static_configs:
      - targets: ["localhost:8080"]

Then run prometheus and dynolog.

./prometheus --config.file prometheus.yml &
cd -
./build/bin/dynolog -kernel_monitor_reporting_interval_s 10 -use_JSON -use_prometheus &

Open https://localhost:9090/

Screenshot 2023-10-16 at 5 52 05 PM
Screenshot 2023-10-16 at 5 53 13 PM
Screenshot 2023-10-16 at 5 53 25 PM
Screenshot 2023-10-16 at 5 53 29 PM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2023
@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@briancoutinho briancoutinho marked this pull request as ready for review October 18, 2023 17:11
Summary:
## Details
1. Add hostname and refactor everyone to common function.
2. Make prometheus-cpp a git submodule and update build scripts
3. Add more metrics, excluding per network and per GPU metrics.
4. Bump version.

# TestPlan

Ran on my laptop using a docker container.

## How to Run
Please install Docker desktop.
1. Download this docker file in a directory https://gist.github.com/briancoutinho/c5faaa60e49a5ad796b972e6b3ef175d
2. Build using docker build . -t prometheus:v2
3. Run docker container forwarding port and mounting dynolog open source repo
`docker run -p 9090:9090 -it -v ~/Work/dynolog_oss/dynolog:/workspace/dynolog prometheus:v2 /bin/bash`
4. Build dynolog ./scripts/build.sh

To get the logging setup add the following in prometheus.yml
```
  - job_name: "dynolog"
    static_configs:
      - targets: ["localhost:8080"]
```
Then run prometheus and dynolog.

```cd /workspace/prometheus/prometheus-2.44.0.linux-amd64;
./prometheus --config.file prometheus.yml &
cd -
./build/bin/dynolog -kernel_monitor_reporting_interval_s 10 -use_JSON -use_prometheus &
```

Open [https://localhost:9090](http://localhost:9090/metrics)/

![Screenshot 2023-10-16 at 5 52 05 PM](https://github.com/facebookincubator/dynolog/assets/6922212/bf19cb2d-654c-4f5f-9f06-e9d2f46c77ef)
![Screenshot 2023-10-16 at 5 53 13 PM](https://github.com/facebookincubator/dynolog/assets/6922212/cf63e741-df68-424f-900e-2bb8d6d8c221)
![Screenshot 2023-10-16 at 5 53 25 PM](https://github.com/facebookincubator/dynolog/assets/6922212/717d0704-4f4d-4c66-8dc4-d7b1c70dc40e)
![Screenshot 2023-10-16 at 5 53 29 PM](https://github.com/facebookincubator/dynolog/assets/6922212/81fd1fa5-e487-423c-9096-926120978032)

Pull Request resolved: #181

Test Plan:
Imported from GitHub, without a `Test Plan:` line.
Brian: Come on Test plan was there in the doc :(

Differential Revision: D50393435

Pulled By: briancoutinho

fbshipit-source-id: 89a067c979995b9328be821a595285dbc6fe4dab
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50393435

@facebook-github-bot
Copy link
Contributor

@briancoutinho merged this pull request in 5a138ae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants