Add reducer function to metrics #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45092289 |
Summary: Pull Request resolved: facebookincubator#133 ## About We can define hbt metrics in terms of a multiple events. However, we lack a way to specify the formula to combine these events, today that is done manually outside in code or by the user directly. We add an optional "reducer" functor to our metric definition that helps identify how to reduce performance events.. Included * Reducer functor type definition and adding it to Metric class (Metric.h/.cpp. * Perf ReadValues leverages the reducer functor to combine multiple events (CpuEventsGroup.h). * Include a simple addition and rate reducer (BuiltinMetrics.h). * Use the rate reducer in instructions/cycle. Differential Revision: D45092289 fbshipit-source-id: f7318c79778296f052ac499299423764710f1888
cb7c279 to
a151778
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45092289 |
|
This pull request has been merged in e5c1002. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
About
We can define hbt metrics in terms of a multiple events. However, we lack a way to specify the formula to combine these events,
today that is done manually outside in code or by the user directly.
We add an optional "reducer" functor to our metric definition that helps identify how to reduce performance events..
Included
Differential Revision: D45092289