workaround vrh task handle longer than max unix socket path #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D44050720 |
haowangludx
pushed a commit
to haowangludx/dynolog-1
that referenced
this pull request
Mar 23, 2023
…incubator#121) Summary: Pull Request resolved: facebookincubator#121 UNIX socket has limit on socket name to be 108, there are tupperware task that has longer than 108 characters. This diff - truncates the construction of DynoIPCLogger to last 106 bytes of the tw task name, because the region/cluster info is usually not useful for identifying the task - change the matching logic in GPU and Task module to be sub-string Reviewed By: jj10306 Differential Revision: D44050720 fbshipit-source-id: 455cdf2dc687d85e81b872ab3fa02405a0b5e7df
bedbc64 to
2a82139
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44050720 |
haowangludx
pushed a commit
to haowangludx/dynolog-1
that referenced
this pull request
Mar 23, 2023
…incubator#121) Summary: Pull Request resolved: facebookincubator#121 UNIX socket has limit on socket name to be 108, there are tupperware task that has longer than 108 characters. This diff - truncates the construction of DynoIPCLogger to last 106 bytes of the tw task name, because the region/cluster info is usually not useful for identifying the task - change the matching logic in GPU and Task module to be sub-string Reviewed By: jj10306 Differential Revision: D44050720 fbshipit-source-id: 9518db8df5a7a140fc049ba71af2ee659f910f8e
2a82139 to
6a8e707
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44050720 |
haowangludx
pushed a commit
to haowangludx/dynolog-1
that referenced
this pull request
Mar 23, 2023
…incubator#121) Summary: Pull Request resolved: facebookincubator#121 UNIX socket has limit on socket name to be 108, there are tupperware task that has longer than 108 characters. This diff - truncates the construction of DynoIPCLogger to last 106 bytes of the tw task name, because the region/cluster info is usually not useful for identifying the task - change the matching logic in GPU and Task module to be sub-string Reviewed By: jj10306 Differential Revision: D44050720 fbshipit-source-id: 98b2e2d80631f0c96bc7d107fc45b416a729bd39
6a8e707 to
fbfbfed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44050720 |
haowangludx
pushed a commit
to haowangludx/dynolog-1
that referenced
this pull request
Mar 23, 2023
…incubator#121) Summary: Pull Request resolved: facebookincubator#121 UNIX socket has limit on socket name to be 108, there are tupperware task that has longer than 108 characters. This diff - truncates the construction of DynoIPCLogger to last 106 bytes of the tw task name, because the region/cluster info is usually not useful for identifying the task - change the matching logic in GPU and Task module to be sub-string Reviewed By: jj10306 Differential Revision: D44050720 fbshipit-source-id: ccbcd68c6c4e50d4cefc0f54b872b2879b0124d4
fbfbfed to
b183d7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44050720 |
…incubator#121) Summary: Pull Request resolved: facebookincubator#121 UNIX socket has limit on socket name to be 108, there are tupperware task that has longer than 108 characters. This diff - truncates the construction of DynoIPCLogger to last 106 bytes of the tw task name, because the region/cluster info is usually not useful for identifying the task - change the matching logic in GPU and Task module to be sub-string Reviewed By: jj10306 Differential Revision: D44050720 fbshipit-source-id: df4e820db261a1e2a2952f360408ef8d60bf8f16
b183d7a to
5693aae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44050720 |
|
This pull request has been merged in 6d9eba9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
UNIX socket has limit on socket name to be 108, there are tupperware task that has longer than 108 characters.
This diff
Reviewed By: jj10306
Differential Revision: D44050720