Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebookincubator/dynolog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.3
Choose a base ref
...
head repository: facebookincubator/dynolog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.0
Choose a head ref
  • 17 commits
  • 42 files changed
  • 4 contributors

Commits on Mar 24, 2023

  1. workaround vrh task handle longer than max unix socket path (#121)

    Summary:
    Pull Request resolved: #121
    
    UNIX socket has limit on socket name to be 108, there are tupperware task that has longer than 108 characters.
    
    This diff
    - truncates the construction of DynoIPCLogger to last 106 bytes of the tw task name, because the region/cluster info is usually not useful for identifying the task
    - change the matching logic in GPU and Task module to be sub-string
    
    Reviewed By: jj10306
    
    Differential Revision: D44050720
    
    fbshipit-source-id: be132a2eedd978933b90e470897c9836e5eb5090
    Hao Wang authored and facebook-github-bot committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    6d9eba9 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Update Milan L3 counters to use recommendations from PPR (#123)

    Summary:
    Pull Request resolved: #123
    
    Update/Add L3 Counters based on the PPR for Milan processors
    
    Reviewed By: jj10306
    
    Differential Revision: D44489085
    
    fbshipit-source-id: b8d378dea29313d8e8dc2bd2e1c535d6b21330d7
    bigzachattack authored and facebook-github-bot committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    d598f73 View commit details
    Browse the repository at this point in the history
  2. Add Zen4 Memory and L3 Counters to AmdEvents (#124)

    Summary:
    Pull Request resolved: #124
    
    Update AmdEvents to include Zen4 events based on Geona PPR (https://www.amd.com/en/support/tech-docs/processor-programming-reference-ppr-for-amd-family-19h-model-11h-revision-b1)
    
    Reviewed By: jj10306
    
    Differential Revision: D44594733
    
    fbshipit-source-id: 135eb70d2da837db1b2df4809daaa2639a73e47c
    bigzachattack authored and facebook-github-bot committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    c599c49 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Fix AMD L2 Prefetches metric and Code cleanups (#126)

    Summary:
    Pull Request resolved: #126
    
    * Add unitMasks for L2 Prefetcher code
    * Add Bergamo and Genoa CPU models
    * Minor code fixups
    
    Reviewed By: jj10306
    
    Differential Revision: D44671393
    
    fbshipit-source-id: 788008a803f850d4283d2ac3f10c72b4a6b3cb15
    bigzachattack authored and facebook-github-bot committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    7a7b645 View commit details
    Browse the repository at this point in the history
  2. Rename (un)likely to avoid conflict with boost (#127)

    Summary:
    Pull Request resolved: #127
    
    Boost has defintions for likely and unlikely that conflict and can cause compiler errors.  Renaming to __hbt_likely and __hbt_unlikley to resolve the conflict.
    
    Reviewed By: jj10306
    
    Differential Revision: D44730441
    
    fbshipit-source-id: dbab963a7afce2504052916b0e4866b9950023cd
    bigzachattack authored and facebook-github-bot committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    72cb3f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Update shm to use std::filesystem and fix minor issues (#129)

    Summary: Pull Request resolved: #129
    
    Reviewed By: jayesh92
    
    Differential Revision: D44000729
    
    fbshipit-source-id: cfccae48c2f1cfe3d872f19a59e2dba63e7249fc
    briancoutinho authored and facebook-github-bot committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b44f444 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Fix aarch64 build (#131)

    Summary:
    Pull Request resolved: #131
    
    aarch64 does not support __rdtsc()
    
    Reviewed By: dmm-fb
    
    Differential Revision: D44916757
    
    fbshipit-source-id: 50ed0dcaec33b6814d1d9d23aee7cd826ec9f742
    psaab authored and facebook-github-bot committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    0fe6f50 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Add get pid function (#130)

    Summary:
    Pull Request resolved: #130
    
    as above
    
    Reviewed By: jayesh92
    
    Differential Revision: D44921379
    
    fbshipit-source-id: 2045696cf3c10058f12b2e519a11f9179cabe8cc
    briancoutinho authored and facebook-github-bot committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ee80d10 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Seperate pfs utilities into a different file to support non linux pla…

    …tform dependencies (#132)
    
    Summary:
    Pull Request resolved: #132
    
    As above
    
    Reviewed By: jayesh92
    
    Differential Revision: D45015343
    
    fbshipit-source-id: 7fcb41a4dd94fad54b933bac762af353225414ff
    briancoutinho authored and facebook-github-bot committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    008606e View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. add thread counter reader (#128)

    Summary:
    Pull Request resolved: #128
    
    Adds thread level counter for hbt
    * Set cpu = -1 to make this thread based perf even
    https://man7.org/linux/man-pages/man2/perf_event_open.2.html
    * Create Thread counter class specializing `CpuEventGroupBase`
    * Avoid verbose prints on PMU sysfs discovery reading?
    
    Reviewed By: haowangludx
    
    Differential Revision: D44764690
    
    fbshipit-source-id: 786f90669c4f05fdc73e5a8e4f2b90513bcea385
    briancoutinho authored and facebook-github-bot committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    23c47e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Add reducer function to metrics (#133)

    Summary:
    Pull Request resolved: #133
    
    ## About
    We can define hbt metrics in terms of a multiple events. However, we lack a way to specify the formula to combine these events,
    today that is done manually outside in code or by the user directly.
    We add an optional "reducer" functor to our metric definition that helps identify how to reduce performance events..
    
    Included
    * Reducer functor type definition and adding it to Metric class (Metric.h/.cpp.
    * Perf ReadValues leverages the reducer functor to combine multiple events (CpuEventsGroup.h).
    * Include a simple addition and rate reducer (BuiltinMetrics.h).
    * Use the rate reducer in instructions/cycle.
    
    Reviewed By: haowangludx
    
    Differential Revision: D45092289
    
    fbshipit-source-id: 2e044915d6595820eddbf95ed7dacfc73c38abfd
    briancoutinho authored and facebook-github-bot committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    e5c1002 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. add resource limits

    briancoutinho committed May 4, 2023
    Configuration menu
    Copy the full SHA
    8198242 View commit details
    Browse the repository at this point in the history
  2. add ubuntu image

    briancoutinho committed May 4, 2023
    Configuration menu
    Copy the full SHA
    bdc525e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    493751a View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. add vim

    briancoutinho committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    d70fccd View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    1fa9301 View commit details
    Browse the repository at this point in the history
  2. typo fix

    briancoutinho committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    75af067 View commit details
    Browse the repository at this point in the history
Loading