Set dictionary ID in ZSTD_initCStream_usingCDict() #511
Conversation
When porting python-zstandard to use ZSTD_initCStream_usingCDict() so compression dictionaries could be reused, an automated test failed due to compressed content changing. I tracked this down to ZSTD_initCStream_usingCDict() not setting the dictID field of the ZSTD_CCtx attached to the ZSTD_CStream instance. I'm not 100% convinced this is the correct or full solution, as I'm still seeing one automated test failing with this change.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thanks for the patch @indygreg . It will also be great to add a relevant test case, as this bug should have already been exposed. I'll take care of this part. Our rules require CLA to be completed. This is a one-time process, you won't need to do it again for future patches. Alternatively, should you prefer it, I can also manually push the same fix from my own clone. |
|
The Facebook CLA tool is confused: when I go to complete the form, it tells me I've already registered my email address. I sent an email to Facebook, but my guess is I won't hear back until after the USA holiday today. Sorry for no test case - I wasn't sure where/how to code that. Go ahead and push the same fix from your clone if you want. |
|
Sorry for your bad experience with the CLA process. In parallel, I'll start developing a test case for this issue. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@indygreg Ok. The CLA issue should be resolved now. Sorry about that. |
|
I've added the test checking I'll push it to github, and then merge your patch. |
|
works great ! |
When porting python-zstandard to use ZSTD_initCStream_usingCDict()
so compression dictionaries could be reused, an automated test
failed due to compressed content changing.
I tracked this down to ZSTD_initCStream_usingCDict() not
setting the dictID field of the ZSTD_CCtx attached to the
ZSTD_CStream instance.
I'm not 100% convinced this is the correct or full solution,
as I'm still seeing one automated test failing with this change.