-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add support for Apple framework builds #4259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Treata11 <treata11@yahoo.com>
Signed-off-by: Treata11 <treata11@yahoo.com>
Why is the Note that increasing the minimum In this case, dropping support for Ubuntu 18 Now, assuming we nonetheless want to increase the minimum version, In this case, the impact looks limited: Note that, in contrast with the minimum version, |
@Cyan4973, thank you for the clarification. cmake -B build -G Xcode -DCMAKE_TOOLCHAIN_FILE=<path to ios.toolchain.cmake> -DPLATFORM=OS64 -DZSTD_FRAMEWORK=ON |
Generally, our support policy is closer to 10 years, I like the second solution you propose. |
All done! |
Would it be possible to have a test in CI that checks this functionality ? |
It's possible to create a build job with |
Yes, that will be good enough |
Greetings,
In order to enable iOS-derived compilations, I firstly had to bump the minimum CMake version to 3.14 and I also introduced a new flag,
ZSTD_FRAMEWORK
, which is set to FALSE by default.I introduced the required properties for framework generation as described in CMake docs
And building is successful using the following commands: