Skip to content

Conversation

r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Apr 26, 2024

Makes this place nicely when header is used in C++ Files.

Copy link
Contributor

@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code needs to compile properly on a large base of C90 compilers.
Please write this modification in a more portable way.

@r-barnes
Copy link
Contributor Author

@Cyan4973 - It looks good now. @terrelln seems happy with the associated D56650471.

Copy link
Contributor

@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@terrelln
Copy link
Contributor

Thanks @r-barnes!

@terrelln terrelln merged commit 97291fc into facebook:dev Apr 29, 2024
@r-barnes r-barnes deleted the patch-1 branch May 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants