-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Labels
enhancementgood first issuelong-termvalid topics that are expected take a long time to make progressvalid topics that are expected take a long time to make progress
Description
There is a safety check in all zstd dictionary matchfinders which checks that the 4-byte repcode match candidate doesn't span across the dictionary and the prefix:
if (((U32) ((prefixStartIndex - 1) - repIndex) >= 3) /* intentional underflow : ensure repIndex isn't overlapping dict + prefix */
It would be nice to replace this with a descriptive helper function across all dictionary matchfinders. I don't think this is release blocking, but I'm opening the issue to track it since it would be a nice improvement.
Cyan4973 and varshneydevansh
Metadata
Metadata
Assignees
Labels
enhancementgood first issuelong-termvalid topics that are expected take a long time to make progressvalid topics that are expected take a long time to make progress