Improvement/add linter #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add npm package * add npm pretest script
* add .jshintrc * address semicolon errors * ignore 'already defined' errors
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
Have you tried using eslint? We're moving towards using it at Facebook and would be awesome if this project would as well
|
Ill switch it over eslint! |
…ut into improvement/add-linter
* modify .eslintrc w/ globals & rules * use judgement in deciding bet proj style & eslint recommendation * make
|
This was quite a messy change adding eslint and addressing the errors so I will fully understand if you decide to reject it T.T. The main comment has been updated. |
|
I'm in vacation until the end of the week. Will check when I get back home, sorry for the wait :( |
| @@ -348,7 +352,7 @@ var layoutTestUtils = (function() { | |||
|
|
|||
| var texts = { | |||
| small: 'small', | |||
| big: 'loooooooooong with space', | |||
There was a problem hiding this comment.
Facebook convention is to always put trailing comma fyi :)
|
So good, lots of great stuff here :) Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed:
Feedback is much appreciated!