Skip to content

Added perspective transform support for Android #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added perspective transform support for Android #6926

wants to merge 1 commit into from

Conversation

kevinstumpf
Copy link

Note: This is an update to the original PR #6159, which got reverted with ae3dad8 after Issue #6622 arose. The old implementation didn't handle the case in which no perspective was set but negative scale or rotationX/Y transforms were applied (See here). This led in the old implementation to an infinite camera distance, resulting in the aforementioned issue #6622. That case is now handled -- I tested all cases described in #6622 to ensure that the Android behavior matches iOS.

Details of the original PR, which still apply:

image

image

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @clickthisnick, @mkonicek and @kmagiera to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 11, 2016
@kevinstumpf kevinstumpf mentioned this pull request Apr 11, 2016
Closed
@mkonicek
Copy link
Contributor

Thanks for fixing the negative scale transform! cc @kmagiera who said he'd like to review this.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @kmagiera, @clickthisnick and @mkonicek to be potential reviewers.

@ghost
Copy link

ghost commented May 5, 2016

@sebmarkbage would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

@satya164
Copy link
Contributor

satya164 commented May 5, 2016

Awesome work! Would be great if you could add this to UIExplorer too.

@nihgwu
Copy link
Contributor

nihgwu commented Jun 27, 2016

any news?

@felipemartim
Copy link

felipemartim commented Jun 30, 2016 •
edited
Loading

Is there any way I can help to get this merged?

@sebmarkbage
Copy link
Contributor

cc @lexs who might be able to review or find someone who can.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2016
@nihgwu nihgwu mentioned this pull request Sep 5, 2016
Closed
@mkonicek mkonicek assigned lexs and unassigned kmagiera Sep 9, 2016
@mkonicek
Copy link
Contributor

mkonicek commented Sep 9, 2016

@lexs Could you take a look please?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016
@lexs
Copy link
Contributor

lexs commented Sep 9, 2016

Sorry for this getting lost.

This code have changed a bunch so it will need to be rebased and updated: see https://github.com/facebook/react-native/blame/master/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2016
@lacker
Copy link
Contributor

lacker commented Oct 24, 2016

It looks like this pull request has been abandoned. Sorry for not getting a faster response in the first place - it does look like this functionality is pretty cool. I'm going to close this pull request but if you are still interested in working on it then please feel free to reopen it because the functionality does seem pretty cool.

@lacker lacker closed this Oct 24, 2016
@satya164 satya164 self-assigned this Jan 3, 2017
@satya164 satya164 mentioned this pull request Jan 4, 2017
Closed
facebook-github-bot pushed a commit that referenced this pull request Feb 4, 2017
@satya164 @facebook-github-bot
Add perspective transform support on Android
a06ced4 
Summary:
Rebased #6926 against master.

Fixes #2915
Closes #11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
edmofro pushed a commit to edmofro/react-native that referenced this pull request Feb 6, 2017
@satya164
Add perspective transform support on Android
352176a 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 7, 2017
@satya164 @nicktate
Add perspective transform support on Android
df181f9 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
normanjoyner pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @normanjoyner
Add perspective transform support on Android
8ffad61 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @nicktate
Add perspective transform support on Android
3a947e4 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @nicktate
Add perspective transform support on Android
626de13 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @nicktate
Add perspective transform support on Android
5a3dc47 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @nicktate
Add perspective transform support on Android
0f824b5 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @nicktate
Add perspective transform support on Android
e3d8e63 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @nicktate
Add perspective transform support on Android
553fb0f 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @nicktate
Add perspective transform support on Android
a6272b8 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@satya164 @nicktate
Add perspective transform support on Android
2659af7 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
GaborWnuk pushed a commit to GaborWnuk/react-native that referenced this pull request Feb 28, 2017
@satya164
Add perspective transform support on Android
558bda1 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
maarf pushed a commit to fullcontact/react-native that referenced this pull request Apr 26, 2017
@satya164 @maarf
Add perspective transform support on Android
db8ac03 
Summary:
Rebased facebook#6926 against master.

Fixes facebook#2915
Closes facebook#11713

Differential Revision: D4513111

fbshipit-source-id: 9fb653c4bfd64eda12a605f6cabb0159b2af8f73
@wcandillon
Copy link
Contributor

Hello gang 🙋🏼‍♂️

Perspective seems to work differently on Android in compare to android. Is anyone aware of these differences and maybe could guide me on what they are?

@wcandillon
Copy link
Contributor

wcandillon commented Nov 13, 2018 •
edited
Loading

On Android there is a default perspective set. I struggling to find its value. I have a 3d rotation that depends on the perspective value. Works great on iOS but fails on Android because, I don't know which value I should assume for the perspective: https://snack.expo.io/@wcandillon/instagram-stories

I looked at the source code and tried some values like 1280, 1280density, or 1280density*5 without success.
I would love to know which transform to apply in order to "revert" the effect of the default perspective on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lexs lexs

@satya164 satya164

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.