Skip to content

Update showcase.js #6912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update showcase.js #6912

wants to merge 1 commit into from

Conversation

ptkach
Copy link
Contributor

@ptkach ptkach commented Apr 11, 2016

Added new app in showcase.js

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @brentvatne, @manonthemat and @chirag04 to be potential reviewers.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2016
@grabbou
Copy link
Contributor

grabbou commented Apr 19, 2016

Please preserve alphabetical order and also rebase your branch as we have shipped quite a few updates recently. Thank you!

@ptkach
Update showcase.js
38a57d5 
Added new app written in React Native
@facebook-github-bot
Copy link
Contributor

@ptkach updated the pull request.

@ptkach
Copy link
Contributor Author

ptkach commented Apr 19, 2016

Hi, thank you for feedback. I've pushed rebased branch.

@grabbou
Copy link
Contributor

grabbou commented Apr 19, 2016

Thanks!

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in dbac1d8 Apr 19, 2016
ptmt pushed a commit to ptmt/react-native that referenced this pull request May 9, 2016
@ptkach @ptmt
Update showcase.js
3f2d06a 
Summary:Added new app in showcase.js
Closes facebook#6912

Differential Revision: D3196473

fb-gh-sync-id: 8c06763907e5bf998c0f0edd832fd1f032ece35c
fbshipit-source-id: 8c06763907e5bf998c0f0edd832fd1f032ece35c
zebulgar pushed a commit to nightingale/react-native that referenced this pull request Jun 18, 2016
@ptkach @zebulgar
Update showcase.js
2ba4a56 
Summary:Added new app in showcase.js
Closes facebook#6912

Differential Revision: D3196473

fb-gh-sync-id: 8c06763907e5bf998c0f0edd832fd1f032ece35c
fbshipit-source-id: 8c06763907e5bf998c0f0edd832fd1f032ece35c
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@ptkach @bubblesunyum
Update showcase.js
ba430c5 
Summary:Added new app in showcase.js
Closes facebook#6912

Differential Revision: D3196473

fb-gh-sync-id: 8c06763907e5bf998c0f0edd832fd1f032ece35c
fbshipit-source-id: 8c06763907e5bf998c0f0edd832fd1f032ece35c
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptkach @facebook-github-bot @grabbou