Revert strict mode in transform-es2015-modules-commonjs #6686
Conversation
|
By analyzing the blame information on this pull request, we identified @janicduplessis, @martinbigio and @skevy to be potential reviewers. |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
I'll import it manually on Tuesday morning, need to generate shrinkwrap |
|
@janicduplessis Should this be cherry-picked to 0.23? What bug does this fix? Here are the other bugfixes we're cherry-picking: #6559 |
|
Martin, not really needed to be reverted, AFAIK. On Fri, Apr 1, 2016 at 4:49 PM, Martin Konicek notifications@github.com
|
|
It was causing some issues with external libraries, I think we just need to publish the babel-preset-react-native@1.5.4 on npm, no need to cherry pick. |
|
Thanks guys! |
|
On npm babel-preset-react-native@1.5.6 is latest, so, it is all clear |
Summary:See discussion here facebook#5796 (comment) **Test plan (required)** Change the babel-preset-react-native dependency to `"babel-preset-react-native": "file:./babel-preset",` so it uses the local babel-preset instead of the one from npm. ``` ./packager/packager.sh --reset-cache ``` open `http://localhost:8081/Examples/UIExplorer/UIExplorerApp.android.bundle?platform=android&dev=true&hot=false&minify=false` and there should not be any added 'strict mode'. Closes facebook#6686 Reviewed By: mkonicek Differential Revision: D3103122 Pulled By: bestander fb-gh-sync-id: 85658ee01bb73f13dacb2b6a48ab121324c13118 fbshipit-source-id: 85658ee01bb73f13dacb2b6a48ab121324c13118
See discussion here #5796 (comment)
Test plan (required)
Change the babel-preset-react-native dependency to
"babel-preset-react-native": "file:./babel-preset",so it uses the local babel-preset instead of the one from npm.open
http://localhost:8081/Examples/UIExplorer/UIExplorerApp.android.bundle?platform=android&dev=true&hot=false&minify=falseand there should not be any added 'strict mode'.